Fix CI: stdin pack reads + stale motion goldens#32
Closed
StuMason wants to merge 2 commits into
Closed
Conversation
Two unrelated breakages that have kept main red since #28: 1. loadPack re-opened /dev/stdin by path, which now fails with ENXIO when the pipe's write end has already closed (spawnSync with input: on current runners). Read fd 0 directly for '-' or '/dev/stdin'. 2. The engine syncs (#28-#30) improved the motionBlur/push graph - real fps oversampling before zoompan instead of zoompan frame duplication (tmix over duplicated frames produced no blur), and dropped a redundant double fps=30 - but the golden snapshots were never regenerated. Regenerated with GOLDEN=1; only look-blur and moves drift, exactly matching the shipped engine behaviour. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Owner
Author
|
Superseded: the CI fix landed on main via #31 (same commits, folded into that branch). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main has been red since #28. Two fixes:
loadPackre-opened/dev/stdinby path, which fails once the pipe's write end is closed (spawnSyncwithinput:on current runners/Node). Now reads fd 0 directly for-//dev/stdin.zoompan(the oldd=3duplication fedtmixidentical frames, i.e. no actual motion blur) and removed a doubledfps=30. Goldens regenerated withGOLDEN=1; onlylook-blurandmovesdrift.72/72 locally. Unblocks #31, #24, #25.
🤖 Generated with Claude Code