Skip to content

fix(release): use PAT for the github release so notify.yaml fires (#9) - #10

Merged
Synertry merged 1 commit into
releasefrom
main
Jun 9, 2026
Merged

fix(release): use PAT for the github release so notify.yaml fires (#9)#10
Synertry merged 1 commit into
releasefrom
main

Conversation

@Synertry

@Synertry Synertry commented Jun 9, 2026

Copy link
Copy Markdown
Owner

The Create GitHub Release step has been using the default GITHUB_TOKEN.
That hit a documented GitHub Actions guardrail: events triggered by
GITHUB_TOKEN do not cascade into downstream workflows (loop protection).
Result: v0.0.1 and v0.0.2 both published cleanly but neither fired the
release.published event, so notify.yaml never ran.

Passing secrets.PAT (already configured in this repo for the integrate +
review-approval workflows) attributes the release to a real identity,
which lets the release.published event propagate to notify.yaml.

Verified by inspecting actions/runs?event=release for the repo, which
returned total_count=0 across the entire repo history.

Signed-off-by: Synertry 60792595+Synertry@users.noreply.github.com

The Create GitHub Release step has been using the default GITHUB_TOKEN.
That hit a documented GitHub Actions guardrail: events triggered by
GITHUB_TOKEN do not cascade into downstream workflows (loop protection).
Result: v0.0.1 and v0.0.2 both published cleanly but neither fired the
release.published event, so notify.yaml never ran.

Passing secrets.PAT (already configured in this repo for the integrate +
review-approval workflows) attributes the release to a real identity,
which lets the release.published event propagate to notify.yaml.

Verified by inspecting actions/runs?event=release for the repo, which
returned total_count=0 across the entire repo history.

Signed-off-by: Synertry <60792595+Synertry@users.noreply.github.com>
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@Synertry Synertry added the workflow/auto-pr Pull request opened by an automated workflow label Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Release Candidate Summary

Automation report for review before merging into release.

Statistics

  • Commits: 1
  • Files Changed: 1

Changed Files

Click to expand file list
M	.github/workflows/release.yaml

Commit History

Click to expand commit log

Generated by GitHub Actions for Release Verification

@github-actions github-actions Bot added area/CI GitHub workflows, Dependabot, labelers, scripts status/review-needed Requires human review before merging status/approval-pending Waiting on approver before fast-forward to release size/xs Extra small diff (< 25 lines, 1 file) and removed status/review-needed Requires human review before merging labels Jun 9, 2026
@Synertry Synertry added status/approved Approved for release - triggers fast-forward push and removed status/approval-pending Waiting on approver before fast-forward to release labels Jun 9, 2026
@Synertry
Synertry merged commit 3f186a9 into release Jun 9, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/CI GitHub workflows, Dependabot, labelers, scripts size/xs Extra small diff (< 25 lines, 1 file) status/approved Approved for release - triggers fast-forward push workflow/auto-pr Pull request opened by an automated workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants