fix(release): use PAT for the github release so notify.yaml fires - #9
Merged
Conversation
The Create GitHub Release step has been using the default GITHUB_TOKEN. That hit a documented GitHub Actions guardrail: events triggered by GITHUB_TOKEN do not cascade into downstream workflows (loop protection). Result: v0.0.1 and v0.0.2 both published cleanly but neither fired the release.published event, so notify.yaml never ran. Passing secrets.PAT (already configured in this repo for the integrate + review-approval workflows) attributes the release to a real identity, which lets the release.published event propagate to notify.yaml. Verified by inspecting actions/runs?event=release for the repo, which returned total_count=0 across the entire repo history. Signed-off-by: Synertry <60792595+Synertry@users.noreply.github.com>
github-actions
Bot
added
area/CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous v0.0.1 and v0.0.2 releases published cleanly but `notify.yaml` never ran. The repo has zero `release`-event workflow runs in its history (`gh api 'actions/runs?event=release'` returns `total_count: 0`).
Why
GitHub Actions has a documented loop-protection guardrail: events triggered by `GITHUB_TOKEN` do not cascade into other workflows. The `Create GitHub Release` step was using the default `GITHUB_TOKEN`, so the `release.published` event got suppressed downstream. notify.yaml's trigger filter (`release.published` only) saw nothing to react to.
Side effect of the suppression: GitHub emits placeholder failure runs on each push for any workflow file whose trigger doesn't match the current event, which is why `gh run list --workflow=notify.yaml` showed a string of "failed" runs all with `event: push` and zero jobs. Those weren't real failures, just GitHub's way of surfacing that nothing fired.
Changes