fix: complete the gallery quality pass — turntable regression, three old-era restages#65
Merged
Merged
Conversation
…tually renders (incorrect PASS in #62)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the gallery quality pass. Pass two (#62) fixed seven examples but shipped one regression and left three in-scope examples in the old washed style because their verdicts were wrong. This PR fixes exactly those defects and runs the whole-gallery acceptance test that pass two skipped.
Incorrect prior verdicts — flagged for the record
FRAMES // 4= ~82° of turn), showing Suzanne face-away where the muzzle and ear read as corrupted geometry. Accepted in review because the reviewer knew what it was; a stranger doesn't.Fixes in this PR (one commit per example)
Mesh.shade_smooth(). House staging kept.docs/VISUAL-STYLE.md: spec floor/world values, shaped warm key (650 W), faint cool fill, warm wedge raking the wall,Standardview transform. The crimson now reads saturated instead of brick.Standardtransform). The steel material the script always specified finally shows: bright machined face, dark tooth flanks, warm pool behind.Reconciled scope — all 14 pre-#61 examples accounted for
Phase 3 — whole-gallery acceptance (mandatory, executed)
Gallery regenerated via
scripts/build_gallery.py, served locally withpython -m http.serverfromdocs/(the prior run's exit 127 was the server being killed intentionally after use, not a failure to serve), loaded in a real browser at a viewport tall enough to defeat lazy-loading, and scrolled end to end with every thumbnail loaded. Confirmed: no card reads as old-era, no render reads as broken geometry, and the six post-#61 examples still lead.Verification
Proven by live run (local): check-only exit 0 on Blender 4.5.11 LTS and 5.1.2 for all four touched examples — including both sides of turntable's slotted-actions channelbag shim and its EEVEE engine-id gate (the 4.5 run exercises
strip.channelbag, the 5.1 runaction_ensure_channelbag_for_slot). All renders on 5.1.2 EEVEE; every candidate inspected at full size, card crop, and thumbnail scale. swatch-grid untouched this pass — its shim coverage stands from #62.Established by inspection only:
--engine cyclesrender paths and the 4.5 EEVEE-Next render path (identical scene code behind the existing engine-id gates; CI smoke is check-only by design).No check tolerances touched; no generated pages hand-edited; release-owned version fields untouched. Alt texts verified against the new renders — all four remain accurate (bmesh-gear's alt finally matches its render).
🤖 Generated with Claude Code