refactor: reuse hook invocation parser in standalone runners - #268
Merged
LadyBluenotes merged 1 commit intoSep 11, 2026
Merged
Conversation
Contributor
|
Warning Review limit reachedNext included review available in 51 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 20d7ea3
☁️ Nx Cloud last updated this comment at |
commit: |
This was referenced Sep 11, 2026
LadyBluenotes
added a commit
that referenced
this pull request
Sep 11, 2026
… hot path Query Git for ignored paths only when an uncovered change needs classifying, and check files coverage once per skills root instead of once per skill file. Benchmarks match the #268 baseline within noise.
LadyBluenotes
added this pull request to stack #274
September 11, 2026 22:02
LadyBluenotes
added a commit
that referenced
this pull request
Sep 11, 2026
… hot path Query Git for ignored paths only when an uncovered change needs classifying, and check files coverage once per skills root instead of once per skill file. Benchmarks match the #268 baseline within noise.
LadyBluenotes
force-pushed
the
refactor-hook-parser-source
branch
from
September 11, 2026 22:22
20d7ea3 to
7d3a67c
Compare
LadyBluenotes
added a commit
that referenced
this pull request
Sep 11, 2026
… hot path Query Git for ignored paths only when an uncovered change needs classifying, and check files coverage once per skills root instead of once per skill file. Benchmarks match the #268 baseline within noise.
LadyBluenotes
force-pushed
the
refactor-hook-parser-source
branch
from
September 11, 2026 22:25
7d3a67c to
5c204d5
Compare
LadyBluenotes
added a commit
that referenced
this pull request
Sep 11, 2026
… hot path Query Git for ignored paths only when an uncovered change needs classifying, and check files coverage once per skills root instead of once per skill file. Benchmarks match the #268 baseline within noise.
LadyBluenotes
force-pushed
the
refactor-hook-parser-source
branch
from
September 11, 2026 22:30
5c204d5 to
a17880b
Compare
LadyBluenotes
added a commit
that referenced
this pull request
Sep 11, 2026
…CLI (#273) * feat: register developer tasks and retire skills from the maintainer CLI maintainer add --task records the developer tasks in domain_map.yaml so a one-skill batch no longer needs a hand edit before check passes. maintainer remove <name> retires a registered skill in the tree and notes it in the spec without deleting authored guidance; it refuses while the skill is selected for distribution or required by another skill. review --json reports include the outcomes and fields a recording needs. * docs: teach the packaged procedure the new maintainer commands Describe --task, remove, package inference, review.ignore, interactive review, and the report's recording block. Inline the skill tree entry format so a one-task authoring read no longer loads the full tree generator skill. * perf: keep review ignore queries and validate coverage checks off the hot path Query Git for ignored paths only when an uncovered change needs classifying, and check files coverage once per skills root instead of once per skill file. Benchmarks match the #268 baseline within noise.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Stacked on #267. Addresses the bounded parser-sharing result of #239.
Generate the standalone runner parser from the tested, self-contained
parseIntentInvocationfunction. Remove the duplicated escaped regex and parser body from the installer template. No new runtime asset, dependency, or framework.Investigation Outcome
The generation contract is that the parser stays self-contained after bundling. A packed-CLI test installs and copies the emitted scripts, then checks denial before a command observation and allowance afterward. The three-agent runtime matrix covers supported command runners and non-command exclusions.
Verification
44 hook-policy, installed-runner, and packed-release tests passed. Build, typecheck, focused ESLint, Knip, Prettier, and
git diff --checkpassed. Guide and dependency files are unchanged.✅ Checklist
pnpm run test:pr.🚀 Release Impact