Skip to content

feat: register developer tasks and retire skills from the maintainer CLI - #273

Merged
LadyBluenotes merged 3 commits into
feat/maintainer-ergonomicsfrom
feat/maintainer-authoring-commands
Sep 11, 2026
Merged

feat: register developer tasks and retire skills from the maintainer CLI#273
LadyBluenotes merged 3 commits into
feat/maintainer-ergonomicsfrom
feat/maintainer-authoring-commands

Conversation

@LadyBluenotes

@LadyBluenotes LadyBluenotes commented Sep 11, 2026

Copy link
Copy Markdown
Member

🎯 Changes

Stacked on #272. Closes the two remaining hand edits in the one-skill authoring path (#238) and gives agents the recording vocabulary in the report itself.

  • maintainer add --task <text> (repeatable) records the developer tasks in domain_map.yaml at registration. Without it, status and check reported record the assessed developer tasks in domain_map.yaml until the maintainer edited the YAML by hand.
  • maintainer remove <name> sets the tree entry to status: retired and appends a note to skill_spec.md. It never deletes SKILL.md; it prints the path to delete once the guidance is no longer needed. It refuses while the skill is selected for repository distribution or required by another active skill, naming what to change first.
  • review --json includes a recording block: the allowed outcomes, the narrower planningOutcomes, the required fields, and the record command. --record ignores the block, so existing annotated reports still record.
  • Packaged generate-skill references describe the new flags, package inference from the working directory, review.ignore, interactive review, and the recording block. planning-records.md now inlines the skill tree entry format, so a one-task authoring read no longer needs the 20 KB tree-generator skill for one anchor.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 617180c2-cbd9-47c7-9fef-a54d987a0b41

📥 Commits

Reviewing files that changed from the base of the PR and between cef37f9 and 6684b48.

📒 Files selected for processing (12)
  • .changeset/maintainer-authoring-commands.md
  • packages/intent/meta/generate-skill/references/maintainer-commands.md
  • packages/intent/meta/generate-skill/references/planning-records.md
  • packages/intent/meta/generate-skill/references/source-review.md
  • packages/intent/src/cli.ts
  • packages/intent/src/commands/maintainer.ts
  • packages/intent/src/commands/validate.ts
  • packages/intent/src/maintainer/add.ts
  • packages/intent/src/maintainer/remove.ts
  • packages/intent/src/review/review.ts
  • packages/intent/tests/maintainer.test.ts
  • packages/intent/tests/review.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@LadyBluenotes
LadyBluenotes added this pull request to stack #274 September 11, 2026 22:02
@LadyBluenotes
LadyBluenotes force-pushed the feat/maintainer-authoring-commands branch from f7c1a1c to ced27b3 Compare September 11, 2026 22:22
@LadyBluenotes
LadyBluenotes force-pushed the feat/maintainer-authoring-commands branch from ced27b3 to 48acc45 Compare September 11, 2026 22:25
maintainer add --task records the developer tasks in domain_map.yaml so a
one-skill batch no longer needs a hand edit before check passes.
maintainer remove <name> retires a registered skill in the tree and notes
it in the spec without deleting authored guidance; it refuses while the
skill is selected for distribution or required by another skill.
review --json reports include the outcomes and fields a recording needs.
Describe --task, remove, package inference, review.ignore, interactive
review, and the report's recording block. Inline the skill tree entry
format so a one-task authoring read no longer loads the full tree
generator skill.
… hot path

Query Git for ignored paths only when an uncovered change needs
classifying, and check files coverage once per skills root instead of
once per skill file. Benchmarks match the #268 baseline within noise.
@LadyBluenotes
LadyBluenotes force-pushed the feat/maintainer-authoring-commands branch from 48acc45 to 6684b48 Compare September 11, 2026 22:30
@LadyBluenotes
LadyBluenotes merged commit 36a1bf1 into main Sep 11, 2026
8 of 11 checks passed
@LadyBluenotes
LadyBluenotes deleted the feat/maintainer-authoring-commands branch September 11, 2026 22:32
@codspeed-hq

codspeed-hq Bot commented Sep 11, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

🆕 9 new benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
🆕 scans a consumer workspace N/A 98.3 ms N/A
🆕 checks a shipped skills tree N/A 157.9 ms N/A
🆕 reports workspace drift N/A 99.1 ms N/A
🆕 loads a direct dependency skill N/A 32.9 ms N/A
🆕 loads a direct dependency from a large workspace N/A 42.1 ms N/A
🆕 loads direct dependency content as json N/A 45.1 ms N/A
🆕 empty node process (baseline) N/A 4.2 ms N/A
🆕 intent --help N/A 4.2 ms N/A
🆕 reports workspace drift with shared artifacts N/A 99.6 ms N/A

Comparing feat/maintainer-authoring-commands (6684b48) with main (2823716)

Open in CodSpeed

@github-actions github-actions Bot mentioned this pull request Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant