test({react,preact}-query/useMutation): add single callback tests for 'onSuccess', 'onError', and 'onSettled' by sukvvon · Pull Request #10487 · TanStack/query

sukvvon · 2026-04-13T17:12:56Z

🎯 Changes

Add 3 runtime tests for useMutation single callback cases in both react-query and preact-query:
- should be able to call 'onSuccess' callback after successful mutate: only onSuccess callback at both useMutation and mutate level
- should be able to call 'onError' callback after failed mutate: only onError callback at both levels
- should be able to call 'onSettled' callback after mutate: only onSettled callback at both levels
Complements existing tests that verify multiple callbacks together (onSuccess + onSettled, onError + onSettled)

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests

Enhanced test coverage for useMutation hook by adding callback invocation ordering tests to verify library-level callbacks execute before per-call callbacks for success, error, and settled scenarios across both React and Preact implementations.

… 'onSuccess', 'onError', and 'onSettled'

coderabbitai · 2026-04-13T17:13:14Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c8f9272c-860a-44e2-a558-3ea70ab33dd9

📥 Commits

Reviewing files that changed from the base of the PR and between 224c073 and b83e14a.

📒 Files selected for processing (2)

packages/preact-query/src/__tests__/useMutation.test.tsx
packages/react-query/src/__tests__/useMutation.test.tsx

📝 Walkthrough

Walkthrough

Added test coverage for callback invocation ordering in useMutation hooks across React and Preact implementations. Three test cases verify that hook-level callbacks (onSuccess, onError, onSettled) execute before their corresponding per-call mutate callbacks.

Changes

Cohort / File(s)	Summary
Callback ordering tests `packages/preact-query/src/__tests__/useMutation.test.tsx`, `packages/react-query/src/__tests__/useMutation.test.tsx`	Added three test cases verifying callback invocation order in `useMutation`: hook-level `onSuccess`, `onError`, and `onSettled` execute before their per-call `mutate` counterparts. Tests use fake timers and validate callback sequence via accumulated arrays.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

test({react,preact}-query/useMutation): add 'mutate' callback override tests #10486: Adds near-identical callback ordering tests to the same useMutation test files across both packages with matching test structure and assertions.

Poem

🐰 Hops through callbacks, neat and true,
Hook runs first, then calls run through,
Order matters, sequence clear,
Tests now verify, no more fear! 🎯

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding single callback tests for onSuccess, onError, and onSettled in both react-query and preact-query useMutation test files.
Description check	✅ Passed	The description provides a clear explanation of changes, follows the required template structure with all sections completed, and includes a properly checked release impact checklist indicating this is a dev-only change.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/react-preact-query-useMutation-single-callback

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-04-13T17:13:23Z

View your CI Pipeline Execution ↗ for commit b83e14a

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 52s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	<1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-04-13 17:17:13 UTC

github-actions · 2026-04-13T17:13:55Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-04-13T17:16:25Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10487

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10487

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10487

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10487

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10487

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10487

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10487

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10487

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10487

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10487

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10487

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10487

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10487

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10487

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10487

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10487

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10487

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10487

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10487

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10487

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10487

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10487

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10487

commit: b83e14a

github-actions · 2026-04-13T17:16:34Z

size-limit report 📦

Path	Size
react full	11.99 KB (0%)
react minimal	9.02 KB (0%)

test({react,preact}-query/useMutation): add single callback tests for…

fb640ab

… 'onSuccess', 'onError', and 'onSettled'

github-actions bot added package: react-query package: preact-query labels Apr 13, 2026

sukvvon self-assigned this Apr 13, 2026

ci: apply automated fixes

b83e14a

sukvvon merged commit eccac7c into main Apr 13, 2026
8 checks passed

sukvvon deleted the test/react-preact-query-useMutation-single-callback branch April 13, 2026 17:27

sukvvon mentioned this pull request Apr 13, 2026

test({react,preact}-query/useMutation): add single callback tests for 'mutateAsync' #10488

Merged

4 tasks

coderabbitai bot mentioned this pull request Apr 13, 2026

test({react,preact}-query/useMutation): add callback tests when 'useMutation' has no callbacks #10489

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test({react,preact}-query/useMutation): add single callback tests for 'onSuccess', 'onError', and 'onSettled'#10487

test({react,preact}-query/useMutation): add single callback tests for 'onSuccess', 'onError', and 'onSettled'#10487
sukvvon merged 2 commits intomainfrom
test/react-preact-query-useMutation-single-callback

sukvvon commented Apr 13, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Apr 13, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

nx-cloud bot commented Apr 13, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 13, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Apr 13, 2026

Uh oh!

github-actions bot commented Apr 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Apr 13, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Tests

Uh oh!

coderabbitai bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

nx-cloud bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Changeset Version Preview

Uh oh!

pkg-pr-new bot commented Apr 13, 2026

Uh oh!

github-actions bot commented Apr 13, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Apr 13, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 13, 2026 •

edited

Loading

nx-cloud bot commented Apr 13, 2026 •

edited

Loading

github-actions bot commented Apr 13, 2026 •

edited

Loading