test({react,preact}-query/useMutation): add single callback tests for 'mutateAsync' by sukvvon · Pull Request #10488 · TanStack/query

sukvvon · 2026-04-13T17:40:38Z

🎯 Changes

Add 3 runtime tests for useMutation single callback cases with mutateAsync in both react-query and preact-query:
- should be able to call 'onSuccess' callback after successful mutateAsync
- should be able to call 'onError' callback after failed mutateAsync
- should be able to call 'onSettled' callback after mutateAsync
Complements existing single callback tests for mutate (test({react,preact}-query/useMutation): add single callback tests for 'onSuccess', 'onError', and 'onSettled' #10487) and multi-callback override tests

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Enhanced test coverage for asynchronous mutation callbacks in both react-query and preact-query packages.

… 'mutateAsync'

nx-cloud · 2026-04-13T17:41:12Z

View your CI Pipeline Execution ↗ for commit be99db1

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 48s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-04-13 17:45:33 UTC

coderabbitai · 2026-04-13T17:41:13Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e364d800-bca6-4d8c-abf7-e72c5a949873

📥 Commits

Reviewing files that changed from the base of the PR and between eccac7c and be99db1.

📒 Files selected for processing (2)

packages/preact-query/src/__tests__/useMutation.test.tsx
packages/react-query/src/__tests__/useMutation.test.tsx

📝 Walkthrough

Walkthrough

Three new test cases added to useMutation tests in both preact-query and react-query packages, validating callback invocation order (onSuccess, onError, onSettled) when using the mutateAsync path. Tests use fake timers to control async execution flow and assert callback sequences. No public API changes.

Changes

Cohort / File(s)	Summary
useMutation mutateAsync callback tests `packages/preact-query/src/__tests__/useMutation.test.tsx`, `packages/react-query/src/__tests__/useMutation.test.tsx`	Added three test cases validating `mutateAsync` callback invocation order: `onSuccess` after successful completion, `onError` after failure with per-call error handler, and `onSettled` after resolution. Tests use fake timers and assert callback execution sequences.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

test({react,preact}-query/useMutation): add 'mutate' callback override tests #10486: Adds complementary callback-order tests for the mutate path in the same test files, covering the synchronous mutation execution flow.
test({react,preact}-query/useMutation): add single callback tests for 'onSuccess', 'onError', and 'onSettled' #10487: Related useMutation callback-order test additions for mutate in identical test files, targeting the same callback ordering validation patterns.

Poem

🐰 Hop and test, the callbacks align,
Success, error, settled—all in line,
Async promises kept in their place,
A well-ordered rabbit's embrace! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely summarizes the main change: adding single callback tests for mutateAsync in both react-query and preact-query packages.
Description check	✅ Passed	The description covers all required sections with appropriate detail: clear bullet points of changes, reference to related work, completed checklist items, and correct release impact marking.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/react-preact-query-useMutation-mutateAsync-single-callback

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-04-13T17:41:39Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-04-13T17:44:52Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10488

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10488

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10488

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10488

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10488

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10488

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10488

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10488

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10488

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10488

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10488

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10488

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10488

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10488

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10488

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10488

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10488

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10488

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10488

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10488

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10488

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10488

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10488

commit: be99db1

github-actions · 2026-04-13T17:45:02Z

size-limit report 📦

Path	Size
react full	11.99 KB (0%)
react minimal	9.02 KB (0%)

test({react,preact}-query/useMutation): add single callback tests for…

8c79ae4

… 'mutateAsync'

github-actions bot added package: react-query package: preact-query labels Apr 13, 2026

sukvvon self-assigned this Apr 13, 2026

ci: apply automated fixes

be99db1

sukvvon merged commit 1b661b3 into main Apr 13, 2026
8 checks passed

sukvvon deleted the test/react-preact-query-useMutation-mutateAsync-single-callback branch April 13, 2026 17:54

This was referenced Apr 13, 2026

test({react,preact}-query/useMutation): add callback tests when 'useMutation' has no callbacks #10489

Merged

test({react,preact}-query/useMutation): add conditional handling and retry tests using 'mutate' callbacks #10491

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test({react,preact}-query/useMutation): add single callback tests for 'mutateAsync'#10488

test({react,preact}-query/useMutation): add single callback tests for 'mutateAsync'#10488
sukvvon merged 2 commits intomainfrom
test/react-preact-query-useMutation-mutateAsync-single-callback

sukvvon commented Apr 13, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

nx-cloud bot commented Apr 13, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Apr 13, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

github-actions bot commented Apr 13, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Apr 13, 2026

Uh oh!

github-actions bot commented Apr 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Apr 13, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

nx-cloud bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

github-actions bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Changeset Version Preview

Uh oh!

pkg-pr-new bot commented Apr 13, 2026

Uh oh!

github-actions bot commented Apr 13, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Apr 13, 2026 •

edited by coderabbitai bot

Loading

nx-cloud bot commented Apr 13, 2026 •

edited

Loading

coderabbitai bot commented Apr 13, 2026 •

edited

Loading

github-actions bot commented Apr 13, 2026 •

edited

Loading