test({react,preact}-query/useMutation): add callback tests when 'useMutation' has no callbacks by sukvvon · Pull Request #10489 · TanStack/query

sukvvon · 2026-04-13T18:14:32Z

🎯 Changes

Add 10 runtime tests for useMutation callback behavior when useMutation has no hook-level callbacks in both react-query and preact-query:
- Combination callbacks:
  - should call mutate callbacks when useMutation has no callbacks (onSuccess + onSettled)
  - should call mutateAsync callbacks when useMutation has no callbacks (onSuccess + onSettled)
  - should call mutate error callbacks when useMutation has no callbacks (onError + onSettled)
  - should call mutateAsync error callbacks when useMutation has no callbacks (onError + onSettled)
- Single callbacks:
  - should call only mutate onSuccess when useMutation has no callbacks
  - should call only mutate onError when useMutation has no callbacks
  - should call only mutate onSettled when useMutation has no callbacks
  - should call only mutateAsync onSuccess when useMutation has no callbacks
  - should call only mutateAsync onError when useMutation has no callbacks
  - should call only mutateAsync onSettled when useMutation has no callbacks

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Enhanced test coverage for useMutation callback execution across success, error, and combined callback scenarios in both React and Preact implementations.

…utation' has no callbacks

coderabbitai · 2026-04-13T18:14:47Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 66ba1487-7d02-400e-857d-781cc39e6360

📥 Commits

Reviewing files that changed from the base of the PR and between 1b661b3 and a464def.

📒 Files selected for processing (2)

packages/preact-query/src/__tests__/useMutation.test.tsx
packages/react-query/src/__tests__/useMutation.test.tsx

📝 Walkthrough

Walkthrough

Added 326 lines of test cases to both React Query and Preact Query packages verifying useMutation callback execution (onSuccess, onError, onSettled) for per-invocation callbacks when no hook-level defaults are configured, covering success and failure scenarios for both mutate and mutateAsync methods.

Changes

Cohort / File(s)	Summary
Preact Query useMutation Tests `packages/preact-query/src/__tests__/useMutation.test.tsx`	Added 326 lines of test cases verifying per-invocation callback behavior for `mutate` and `mutateAsync`, including success/error scenarios with individual and combined callbacks (`onSuccess`, `onError`, `onSettled`).
React Query useMutation Tests `packages/react-query/src/__tests__/useMutation.test.tsx`	Added 326 lines of test cases verifying per-invocation callback behavior for `mutate` and `mutateAsync`, including success/error scenarios with individual and combined callbacks (`onSuccess`, `onError`, `onSettled`).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

test({react,preact}-query/useMutation): add single callback tests for 'mutateAsync' #10488: Introduces overlapping test cases for mutateAsync single-callback behavior in the same test files.
test({react,preact}-query/useMutation): add 'mutate' callback override tests #10486: Adds tests verifying per-call callback invocation and ordering (hook-level vs per-call) in useMutation tests for both React and Preact.
test({react,preact}-query/useMutation): add single callback tests for 'onSuccess', 'onError', and 'onSettled' #10487: Covers useMutation callback tests for onSuccess/onError/onSettled scenarios in the same test files with different specific cases.

Poem

🐰 Tests now bloom in pairs so bright,
React and Preact, side by side,
Callbacks dancing left and right,
Success and errors verified! ✨
A rabbit's hop through mutation's way. 🎉

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding callback tests for useMutation when no hook-level callbacks are present, covering both react-query and preact-query packages.
Description check	✅ Passed	The description follows the template structure with detailed changes listed, completed checklist, and correctly marked as docs/CI/dev-only without requiring a changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/react-preact-query-useMutation-no-hook-callbacks

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-04-13T18:15:19Z

View your CI Pipeline Execution ↗ for commit a464def

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	2m 41s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-04-13 18:20:32 UTC

github-actions · 2026-04-13T18:15:41Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-04-13T18:18:58Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10489

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10489

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10489

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10489

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10489

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10489

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10489

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10489

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10489

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10489

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10489

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10489

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10489

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10489

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10489

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10489

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10489

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10489

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10489

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10489

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10489

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10489

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10489

commit: a464def

github-actions · 2026-04-13T18:19:08Z

size-limit report 📦

Path	Size
react full	11.99 KB (0%)
react minimal	9.02 KB (0%)

test({react,preact}-query/useMutation): add callback tests when 'useM…

c89183a

…utation' has no callbacks

sukvvon self-assigned this Apr 13, 2026

github-actions bot added package: react-query package: preact-query labels Apr 13, 2026

ci: apply automated fixes

a464def

sukvvon merged commit 792d3a5 into main Apr 13, 2026
8 checks passed

sukvvon deleted the test/react-preact-query-useMutation-no-hook-callbacks branch April 13, 2026 18:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test({react,preact}-query/useMutation): add callback tests when 'useMutation' has no callbacks#10489

test({react,preact}-query/useMutation): add callback tests when 'useMutation' has no callbacks#10489
sukvvon merged 2 commits intomainfrom
test/react-preact-query-useMutation-no-hook-callbacks

sukvvon commented Apr 13, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Apr 13, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

nx-cloud bot commented Apr 13, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 13, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Apr 13, 2026

Uh oh!

github-actions bot commented Apr 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Apr 13, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

nx-cloud bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Changeset Version Preview

Uh oh!

pkg-pr-new bot commented Apr 13, 2026

Uh oh!

github-actions bot commented Apr 13, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Apr 13, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 13, 2026 •

edited

Loading

nx-cloud bot commented Apr 13, 2026 •

edited

Loading

github-actions bot commented Apr 13, 2026 •

edited

Loading