Skip to content

fix(start): use appropriate stream transform for renderToReadableStream - #2116

Merged
SeanCassiere merged 1 commit into
TanStack:mainfrom
lithdew:fix/readable-stream
Aug 10, 2024
Merged

fix(start): use appropriate stream transform for renderToReadableStream#2116
SeanCassiere merged 1 commit into
TanStack:mainfrom
lithdew:fix/readable-stream

Conversation

@lithdew

@lithdew lithdew commented Aug 10, 2024

Copy link
Copy Markdown
Contributor

transformStreamWithRouter was previously being used when the runtime is detected to support web streams (i.e. ReadableStream).

transformReadableStreamWithRouter should be used instead inside of defaultStreamHandler.

@nx-cloud

nx-cloud Bot commented Aug 10, 2024

Copy link
Copy Markdown
Contributor

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 475d571. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new

pkg-pr-new Bot commented Aug 10, 2024

Copy link
Copy Markdown

commit: 475d571

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2116

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2116

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2116

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2116

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2116

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2116

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2116

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2116

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2116

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2116

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2116

Open in Stackblitz

More templates

transformStreamWithRouter was previously being used when the runtime is
detected to support web streams (i.e. ReadableStream).

transformReadableStreamWithRouter should be used instead inside of
defaultStreamHandler.
@lithdew
lithdew force-pushed the fix/readable-stream branch from 0e8eb38 to 475d571 Compare August 10, 2024 10:50
@SeanCassiere
SeanCassiere merged commit f4f4250 into TanStack:main Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants