Skip to content

fix(react-router): decode search keys - #2227

Merged
schiller-manuel merged 3 commits into
TanStack:mainfrom
kshramt:decode_key
Aug 31, 2024
Merged

fix(react-router): decode search keys#2227
schiller-manuel merged 3 commits into
TanStack:mainfrom
kshramt:decode_key

Conversation

@kshramt

@kshramt kshramt commented Aug 30, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@kshramt kshramt changed the title fix: Escape search keys fix: Decode search keys Aug 30, 2024
@kshramt kshramt changed the title fix: Decode search keys fix(react-router): decode search keys Aug 30, 2024
@nx-cloud

nx-cloud Bot commented Aug 30, 2024

Copy link
Copy Markdown
Contributor

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e5be722. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new

pkg-pr-new Bot commented Aug 30, 2024

Copy link
Copy Markdown

Open in Stackblitz

More templates

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2227

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2227

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2227

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2227

@tanstack/router-arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/router-arktype-adapter@2227

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2227

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2227

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2227

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2227

@tanstack/router-valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/router-valibot-adapter@2227

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2227

@tanstack/router-zod-adapter

pnpm add https://pkg.pr.new/@tanstack/router-zod-adapter@2227

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2227

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2227

commit: e5be722

@schiller-manuel

Copy link
Copy Markdown
Collaborator

please also add router tests. the following comes to mind: ( add more if other test make sense of course )

  1. initial page load with such encoded query params
  2. navigate to a route with those encoder query params

@SeanCassiere SeanCassiere left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a block till @schiller-manuel comments are resolved.

@kshramt

kshramt commented Aug 31, 2024

Copy link
Copy Markdown
Contributor Author

Thank you for the review. I have added a few tests to (hopefully) address your comments.

please also add router tests. the following comes to mind: ( add more if other test make sense of course )

1. initial page load with such encoded query params

https://github.com/TanStack/router/pull/2227/files#diff-d5945193f3b7ac56e5786cded7d5317ff8fa79dc819dc9f125f8a97d1dbd6aabR481

2. navigate to a route with those encoder query params

https://github.com/TanStack/router/pull/2227/files#diff-d5945193f3b7ac56e5786cded7d5317ff8fa79dc819dc9f125f8a97d1dbd6aabR488

@kshramt
kshramt requested a review from SeanCassiere August 31, 2024 12:59
@schiller-manuel
schiller-manuel merged commit d39d0fd into TanStack:main Aug 31, 2024
@schiller-manuel

Copy link
Copy Markdown
Collaborator

thanks a lot @kshramt for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants