feat(router-plugin): add esbuild plugin - #2578
Merged
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
benmcginnis
marked this pull request as ready for review
October 18, 2024 20:43
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9e5b19d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Addresses #2576 by adding an esbuild plugin to the router-plugin package. Duplicated the basic-file-based e2e test to verify validate the behavior, and replaces the vite config with an esbuild config as well as replacing the vite scripts with esbuild scripts. tested by running: pnpm run test:e2e from within the e2e/react-router/basic-esbuild-file-based directory.
This change adds a quick start example for esbuild. It also addresses some feedback from the [#2578](PR): - updates the file-based-routing docs - updates the router-plugin's vite config
SeanCassiere
approved these changes
Oct 22, 2024
SeanCassiere
left a comment
Member
There was a problem hiding this comment.
The changes look good.
Now just need to figure out why CI is failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #2576 by adding an esbuild plugin to the router-plugin package.
Duplicated the basic-file-based e2e test to verify validate the behavior, and replaces the vite config with an esbuild config as well as replacing the vite scripts with esbuild scripts.
tested by running: pnpm run test:e2e from within the e2e/react-router/basic-esbuild-file-based directory.