Skip to content

feat(router-plugin): add esbuild plugin - #2578

Merged
SeanCassiere merged 6 commits into
TanStack:mainfrom
benmcginnis:esbuild-plugin
Oct 22, 2024
Merged

feat(router-plugin): add esbuild plugin#2578
SeanCassiere merged 6 commits into
TanStack:mainfrom
benmcginnis:esbuild-plugin

Conversation

@benmcginnis

@benmcginnis benmcginnis commented Oct 18, 2024

Copy link
Copy Markdown
Contributor

Addresses #2576 by adding an esbuild plugin to the router-plugin package.

Duplicated the basic-file-based e2e test to verify validate the behavior, and replaces the vite config with an esbuild config as well as replacing the vite scripts with esbuild scripts.

tested by running: pnpm run test:e2e from within the e2e/react-router/basic-esbuild-file-based directory.

@benmcginnis benmcginnis changed the title work in progress, need to figure out appropriate e2e test method Add esbuild plugin Oct 18, 2024
@schiller-manuel schiller-manuel changed the title Add esbuild plugin feat(plugin-router): add esbuild plugin Oct 18, 2024
@schiller-manuel

This comment was marked as resolved.

@benmcginnis
benmcginnis marked this pull request as ready for review October 18, 2024 20:43
@nx-cloud

nx-cloud Bot commented Oct 18, 2024

Copy link
Copy Markdown
Contributor

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9e5b19d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Comment thread e2e/react-router/basic-esbuild-file-based/src/esbuild.config.js Outdated
SeanCassiere

This comment was marked as resolved.

SeanCassiere

This comment was marked as resolved.

Addresses #2576 by adding an esbuild plugin to the router-plugin package.

Duplicated the basic-file-based e2e test to verify validate the
behavior, and replaces the vite config with an esbuild config as
well as replacing the vite scripts with esbuild scripts.

tested by running: pnpm run test:e2e from within the
e2e/react-router/basic-esbuild-file-based directory.
This change adds a quick start example for esbuild.

It also addresses some feedback from the [#2578](PR):
- updates the file-based-routing docs
- updates the router-plugin's vite config

@SeanCassiere SeanCassiere left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good.

Now just need to figure out why CI is failing.

@SeanCassiere SeanCassiere changed the title feat(plugin-router): add esbuild plugin feat(router-plugin): add esbuild plugin Oct 22, 2024
@pkg-pr-new

pkg-pr-new Bot commented Oct 22, 2024

Copy link
Copy Markdown

Open in Stackblitz

More templates

@tanstack/create-router

pnpm add https://pkg.pr.new/@tanstack/create-router@2578

@tanstack/eslint-plugin-router

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-router@2578

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2578

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2578

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2578

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2578

@tanstack/router-arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/router-arktype-adapter@2578

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2578

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2578

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2578

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2578

@tanstack/router-valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/router-valibot-adapter@2578

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2578

@tanstack/router-zod-adapter

pnpm add https://pkg.pr.new/@tanstack/router-zod-adapter@2578

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2578

@tanstack/virtual-file-routes

pnpm add https://pkg.pr.new/@tanstack/virtual-file-routes@2578

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2578

commit: 9e5b19d

@SeanCassiere
SeanCassiere merged commit cea5a11 into TanStack:main Oct 22, 2024
@benmcginnis
benmcginnis deleted the esbuild-plugin branch October 22, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants