fix(start): Send error messages from server functions - #2625
Closed
danecando wants to merge 3 commits into
Closed
Conversation
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f25e09d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Collaborator
|
can you please add tests to the start e2e tests? |
5 tasks
This was referenced Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes some unnecessary logs and passes error messages from server function errors. Passes error messages directly to errors thrown from the client instead of putting a json payload in the message.
This should align better with whats shown in the docs. It seems unsafe to send along server stack traces though.
Would like to support returning other error responses without having them thrown on the client side as well. Curious how other people feel about that.