refactor(start): expose vinxi router middleware - #2893
Merged
Conversation
Extra routers for custom behavior and middleware for custom middleware
Make use of middlewares and extra custom routers
SeanCassiere
requested changes
Dec 2, 2024
| ], | ||
| }) | ||
|
|
||
| opts.routerExtras?.forEach((val => { |
Member
There was a problem hiding this comment.
I'd rather not allow adding extra Vinxi routers using this method.
The addRouter method is what I'd go for.
// app.config.ts
import { defineConfig } from '@tanstack/start/config'
export default defineConfig({
// ...
}).addRouter({
// ...
})
SeanCassiere
approved these changes
Dec 3, 2024
SeanCassiere
left a comment
SeanCassiere
left a comment
Member
There was a problem hiding this comment.
Removed the Vinxi router stuff in favor of .addRouter.
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1811e3c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud. |
SeanCassiere
changed the title
timoconnellaus
pushed a commit
to timoconnellaus/tanstack-router
that referenced
this pull request
Dec 19, 2024
Co-authored-by: Sean Cassiere <33615041+SeanCassiere@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make use of vinxi strength by being able to use custom routers and middlewares on top of tanstack start and routers. To be used by advanced users only.