Skip to content

fix(router-plugin): generation for rspack/webpack builds should use the beforeRun compiler hook #2971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SeanCassiere merged 2 commits into from
Dec 10, 2024
Merged

fix(router-plugin): generation for rspack/webpack builds should use the beforeRun compiler hook #2971

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8fcc0e
fix(router-plugin): rsbuild to await generation using compiler hooks
SeanCassiere Dec 10, 2024
52c0baa
fix(router-plugin): webpack to await generation using compiler hooks
SeanCassiere Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/router-plugin/src/core/router-generator-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@ export const unpluginRouterGeneratorFactory: UnpluginFactory<
userConfig = getConfig(options, ROOT)

if (compiler.options.mode === 'production') {
await run(generate)
compiler.hooks.beforeRun.tapPromise(PLUGIN_NAME, async () => {
await run(generate)
})
} else {
// rspack watcher doesn't register newly created files
const routesDirectoryPath = getRoutesDirectoryPath()
Expand All @@ -117,7 +119,9 @@ export const unpluginRouterGeneratorFactory: UnpluginFactory<
userConfig = getConfig(options, ROOT)

if (compiler.options.mode === 'production') {
await run(generate)
compiler.hooks.beforeRun.tapPromise(PLUGIN_NAME, async () => {
await run(generate)
})
} else {
// webpack watcher doesn't register newly created files
const routesDirectoryPath = getRoutesDirectoryPath()
Expand Down