Skip to content

docs: Slightly improve navigation-blocking.md to avoid confusion - #3015

Merged
schiller-manuel merged 1 commit into
TanStack:mainfrom
reihwald:patch-1
Dec 15, 2024
Merged

docs: Slightly improve navigation-blocking.md to avoid confusion#3015
schiller-manuel merged 1 commit into
TanStack:mainfrom
reihwald:patch-1

Conversation

@reihwald

Copy link
Copy Markdown
Contributor

This is something really small. I'd expect for the reject of the example SaveBlocker:

<SaveBlocker
  confirm={() => {
    modals.closeAll()
    resolve(true)
  }}
  reject={() => {
    modals.closeAll()
    resolve(true)
  }}
/>

to block the navigation instead of letting in through, as it currently does.

I also think that having the inverted shouldLeave is needlessly confusing when not using window.confirm.

@nx-cloud

nx-cloud Bot commented Dec 15, 2024

Copy link
Copy Markdown
Contributor

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b7d40ba. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new

pkg-pr-new Bot commented Dec 15, 2024

Copy link
Copy Markdown

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@3015

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@3015

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@3015

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@3015

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3015

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@3015

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@3015

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@3015

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@3015

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@3015

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@3015

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3015

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@3015

@tanstack/start-vite-plugin

npm i https://pkg.pr.new/@tanstack/start-vite-plugin@3015

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@3015

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3015

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@3015

commit: b7d40ba

@schiller-manuel schiller-manuel changed the title Slightly improve navigation-blocking.md to avoid confusion docs: Slightly improve navigation-blocking.md to avoid confusion Dec 15, 2024
@schiller-manuel
schiller-manuel merged commit f063b49 into TanStack:main Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants