[codex] Add Solid Start pending hydration regression test

[ljho01]

What changed

This adds a Solid Start regression test for ssr: 'data-only' with a slow loader and a pendingComponent that returns a DOM element.

It introduces:

• a dedicated /mre-data-only route under e2e/solid-start/selective-ssr
• a dev-only Playwright config so the hydration path is exercised against the Vite dev server
• a focused Playwright spec that asserts the route hydrates through pending and reaches OK — loader finished without template is not a function or Hydration Mismatch

Why

This is intended to lock in the Solid hydration fix around pendingComponent on data-only routes.

Current main passes this test.
If packages/solid-router/src/Match.tsx is changed from:

(isServer ?? router.isServer) || resolvedNoSsr

to:

(isServer ?? router.isServer) && resolvedNoSsr

the same test fails in dev mode and the route never reaches the loaded UI.

Impact

This gives us a targeted regression test for the exact hydration behavior that previously broke in dev mode for Solid Start.

Validation

Ran:

cd e2e/solid-start/selective-ssr
rm -rf port*.txt && pnpm exec playwright test --config=playwright.dev.config.ts tests/pending-component-hydration.spec.ts --project=chromium

Also manually verified:

• current main / fixed || condition: passes
• local temporary revert to &&: fails
• restored ||: passes again

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 40c5d808-9dab-455e-85f5-f42d5c60e7fa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[nx-cloud]

View your CI Pipeline Execution ↗ for commit 9ece5f9

Command	Status	Duration	Result
nx affected --targets=test:eslint,test:unit,tes...	✅ Succeeded	53s	View ↗
nx run-many --target=build --exclude=examples/*...	✅ Succeeded	2s	View ↗

---

☁️ Nx Cloud last updated this comment at 2026-04-19 15:39:40 UTC

[pkg-pr-new]

More templates

• tanstack-router-vue-example-basic-jsx
• tanstack-router-vue-example-basic-file-based-jsx
• tanstack-router-vue-example-basic-file-based-sfc
• tanstack-router-react-example-authenticated-routes
• tanstack-router-react-example-authenticated-routes-firebase
• tanstack-router-react-example-basic
• tanstack-router-react-example-basic-default-search-params
• tanstack-router-react-example-basic-devtools-panel
• tanstack-router-react-example-basic-file-based
• tanstack-router-react-example-basic-non-nested-devtools
• tanstack-router-react-example-react-query
• tanstack-router-react-example-basic-react-query-file-based
• tanstack-router-react-example-basic-ssr-file-based
• tanstack-router-react-example-basic-ssr-streaming-file-based
• tanstack-router-react-example-basic-virtual-file-based
• tanstack-router-react-example-basic-virtual-inside-file-based
• tanstack-router-react-example-deferred-data
• tanstack-router-i18n-paraglide
• tanstack-router-react-example-kitchen-sink
• tanstack-router-react-example-kitchen-sink-file-based
• tanstack-router-react-example-kitchen-sink-react-query
• tanstack-router-react-example-kitchen-sink-react-query-file-based
• tanstack-router-react-example-large-file-based
• tanstack-router-react-example-location-masking
• tanstack-router-react-example-navigation-blocking
• tanstack-router-react-example-quickstart
• tanstack-router-react-example-quickstart-esbuild-file-based
• tanstack-router-react-example-quickstart-file-based
• tanstack-router-react-example-quickstart-rspack-file-based
• tanstack-router-react-example-quickstart-webpack-file-based
• router-monorepo-react-query
• router-mono-simple
• router-mono-simple-lazy
• tanstack-router-react-example-scroll-restoration
• tanstack-search-validator-adapters
• tanstack-start-example-bare
• tanstack-start-example-basic
• tanstack-start-example-basic-auth
• tanstack-router-react-example-basic-authjs
• tanstack-start-example-basic-cloudflare
• tanstack-start-example-basic-react-query
• tanstack-start-example-basic-rsc
• tanstack-start-example-basic-static
• tanstack-start-bun-hosting
• tanstack-start-example-clerk-basic
• tanstack-start-example-convex-trellaux
• tanstack-start-example-counter
• tanstack-start-i18n-paraglide
• tanstack-start-example-large
• tanstack-start-example-material-ui
• tanstack-start-streaming-data-from-server-functions
• tanstack-start-example-supabase-basic
• tanstack-start-tailwind-v4
• tanstack-start-example-trellaux
• tanstack-start-example-workos
• tanstack-router-react-example-view-transitions
• tanstack-router-react-example-with-framer-motion
• tanstack-router-react-example-with-trpc
• tanstack-router-react-example-with-trpc-react-query
• tanstack-router-solid-example-authenticated-routes
• tanstack-router-solid-example-authenticated-routes-firebase
• tanstack-router-solid-example-basic
• tanstack-router-solid-example-basic-default-search-params
• tanstack-router-solid-example-basic-devtools-panel
• tanstack-router-solid-example-basic-file-based
• tanstack-router-solid-example-basic-non-nested-devtools
• tanstack-router-solid-example-basic-solid-query
• tanstack-router-solid-example-basic-solid-query-file-based
• tanstack-router-solid-example-basic-ssr-file-based
• tanstack-router-solid-example-basic-ssr-streaming-file-based
• tanstack-router-solid-example-basic-virtual-file-based
• tanstack-router-solid-example-basic-virtual-inside-file-based
• tanstack-router-solid-example-deferred-data
• tanstack-router-solid-i18n-paraglide
• tanstack-router-solid-example-kitchen-sink
• tanstack-router-solid-example-kitchen-sink-file-based
• tanstack-router-solid-example-kitchen-sink-solid-query
• tanstack-router-solid-example-kitchen-sink-solid-query-file-based
• tanstack-router-solid-example-large-file-based
• tanstack-router-solid-example-location-masking
• tanstack-router-solid-example-navigation-blocking
• tanstack-router-solid-example-quickstart
• tanstack-router-solid-example-quickstart-esbuild-file-based
• tanstack-router-solid-example-quickstart-file-based
• tanstack-router-solid-example-quickstart-rspack-file-based
• tanstack-router-solid-example-quickstart-webpack-file-based
• @tanstack/router-solid-mono-simple
• router-solid-mono-simple-lazy
• router-solid-monorepo-solid-query
• tanstack-router-solid-example-scroll-restoration
• tanstack-solid-router-search-validator-adapters
• tanstack-solid-start-example-basic
• tanstack-solid-start-example-basic-auth
• tanstack-solid-start-example-basic-authjs
• tanstack-solid-start-example-basic-cloudflare
• tanstack-solid-start-example-basic-netlify
• tanstack-solid-start-example-basic-nitro
• tanstack-start-example-basic-solid-query
• tanstack-solid-start-example-basic-static
• tanstack-solid-start-bun-hosting
• tanstack-solid-start-example-convex-better-auth
• tanstack-solid-start-example-counter
• tanstack-solid-start-i18n-paraglide
• tanstack-solid-start-example-large
• tanstack-solid-start-streaming-data-from-server-functions
• tanstack-solid-start-example-supabase-basic
• tanstack-solid-start-tailwind-v4
• tanstack-router-solid-example-view-transitions
• tanstack-router-solid-example-with-framer-motion
• tanstack-router-solid-example-with-trpc

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7086

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7086

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7086

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7086

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7086

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7086

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7086

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7086

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7086

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7086

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7086

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7086

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7086

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7086

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7086

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7086

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7086

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7086

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7086

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7086

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7086

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7086

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7086

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7086

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7086

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7086

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7086

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7086

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7086

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7086

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7086

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7086

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7086

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7086

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7086

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7086

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7086

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7086

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7086

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7086

commit: 9ece5f9

[brenelz]

Shouldn't the tests be failing if you add a regression test?

[brenelz]

Integrated what I could into this pr

#7266