Fix hydration mismatch for ssr='data-only' with pendingComponent by Copilot · Pull Request #7266 · TanStack/router

Copilot · 2026-04-25T23:23:03Z

Fixes the Solid Router resolvedNoSsr condition so ssr: 'data-only' routes with a pendingComponent hydrate correctly without duplicating suspense fallback output.

Adds Solid Start selective SSR regression coverage for the data-only pending component hydration case, and shares browser error collection through @tanstack/router-e2e-utils.

brenelz · 2026-04-25T23:52:04Z

@copilot Lets try gpt 5.5

nx-cloud · 2026-04-26T00:16:38Z

View your CI Pipeline Execution ↗ for commit 3ff8326

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	❌ Failed	5m 20s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	21s	View ↗

☁️ Nx Cloud last updated this comment at 2026-04-26 02:49:15 UTC

github-actions · 2026-04-26T00:16:59Z

🚀 Changeset Version Preview

1 package(s) bumped directly, 3 bumped as dependents.

🟩 Patch bumps

Package	Version	Reason
`@tanstack/solid-router`	1.168.23 → 1.168.24	Changeset
`@tanstack/solid-start`	1.167.46 → 1.167.47	Dependent
`@tanstack/solid-start-client`	1.166.40 → 1.166.41	Dependent
`@tanstack/solid-start-server`	1.166.41 → 1.166.42	Dependent

pkg-pr-new · 2026-04-26T00:19:02Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7266

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7266

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7266

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7266

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7266

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7266

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7266

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7266

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7266

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7266

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7266

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7266

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7266

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7266

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7266

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7266

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7266

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7266

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7266

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7266

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7266

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7266

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7266

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7266

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7266

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7266

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7266

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7266

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7266

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7266

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7266

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7266

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7266

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7266

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7266

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7266

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7266

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7266

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7266

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7266

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7266

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7266

commit: e22c3b5

github-actions · 2026-04-26T00:19:06Z

Bundle Size Benchmarks

Commit: 65874cd48a26
Measured at: 2026-04-26T02:44:21.824Z
Baseline source: history:aebf4264767a
Dashboard: bundle-size history

Scenario	Current (gzip)	Delta vs baseline	Raw	Brotli	Trend
`react-router.minimal`	87.35 KiB	0 B (0.00%)	274.60 KiB	75.97 KiB	▅▅▅▅▅▅▅▅▅▅▅
`react-router.full`	90.77 KiB	0 B (0.00%)	286.11 KiB	78.90 KiB	▅▅▅▅▅▅▅▅▅▅▅
`solid-router.minimal`	35.58 KiB	0 B (0.00%)	106.86 KiB	31.98 KiB	▁▁▁▁▁▁▁▁███
`solid-router.full`	40.32 KiB	-5 B (-0.01%)	121.07 KiB	36.26 KiB	▁▁▁▁▄▄▄▄▆███
`vue-router.minimal`	53.30 KiB	0 B (0.00%)	152.01 KiB	47.88 KiB	▅▅▅▅▅▅▅▅▅▅▅
`vue-router.full`	58.44 KiB	0 B (0.00%)	168.19 KiB	52.34 KiB	▅▅▅▅▅▅▅▅▅▅▅
`react-start.minimal`	101.92 KiB	0 B (0.00%)	322.77 KiB	88.18 KiB	▅▅▅▅▅▅▅▅▅▅▅
`react-start.full`	105.35 KiB	0 B (0.00%)	333.10 KiB	91.02 KiB	▅▅▅▅▅▅▅▅▅▅▅
`react-start.rsbuild.minimal`	101.43 KiB	0 B (0.00%)	325.62 KiB	87.12 KiB	▁████████
`react-start.rsbuild.full`	104.74 KiB	0 B (0.00%)	336.31 KiB	89.93 KiB	▅▅▅▅▅▅▅▅▅
`solid-start.minimal`	49.58 KiB	+1 B (+0.00%)	152.69 KiB	43.74 KiB	▁▁▁▁▁▁▁▁████
`solid-start.full`	55.37 KiB	+5 B (+0.01%)	169.59 KiB	48.72 KiB	▁▁▁▁▄▄▄▄▅███

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

birkskyum · 2026-04-26T00:20:20Z

+    const browserErrors: Array<string> = []
+
+    page.on('pageerror', (error) => {
+      browserErrors.push(error.message)
+    })
+
+    page.on('console', (message) => {
+      if (message.type() === 'error' || message.type() === 'warning') {
+        browserErrors.push(message.text())
+      }
+    })
+
+    page.on('requestfailed', (request) => {
+      browserErrors.push(
+        `${request.url()} ${request.failure()?.errorText ?? 'failed'}`,
+      )
+    })


@copilot do we have all this in a util somewhere ? it seems quite generic

@copilot resolve this

Added a shared collectBrowserErrors helper in @tanstack/router-e2e-utils and updated this test to use it. Addressed in 92177e3.

Resolved by the existing 92177e3 follow-up: the generic browser error listener is now collectBrowserErrors in @tanstack/router-e2e-utils, and this spec imports it instead of defining it inline.

birkskyum · 2026-04-26T00:20:46Z

@copilot what is mre?

Copilot · 2026-04-26T00:21:57Z

@copilot what is mre?

MRE means “minimal reproducible example” — in this PR it’s the small route added to reproduce the hydration mismatch.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

cloud.nx.app
- Triggering command: /usr/local/bin/node node ./node_modules/.bin/../nx/bin/nx.js run @tanstack/router-e2e-utils:test:eslint --outputStyle=stream --skipRemoteCache (dns block)
- Triggering command: /usr/local/bin/node node ./node_modules/.bin/../nx/bin/nx.js run tanstack-solid-start-e2e-selective-ssr:test:e2e --outputStyle=stream --skipRemoteCache (dns block)
- Triggering command: /usr/local/bin/node node ./node_modules/.bin/../nx/bin/nx.js run tanstack-solid-start-e2e-selective-ssr:test:e2e --outputStyle=stream --skipRemoteCache -- tests/pending-component-hydration.spec.ts (dns block)
sparrow.cloudflare.com
- Triggering command: /usr/local/bin/node /usr/local/bin/node --no-warnings --experimental-vm-modules /home/REDACTED/work/router/router/node_modules/.pnpm/wrangler@4.75.0/node_modules/wrangler/wrangler-dist/cli.js types (dns block)
www.google-analytics.com
- Triggering command: /usr/local/bin/node node ./node_modules/.bin/../nx/bin/nx.js show project tanstack-solid-start-e2e-selective-ssr --json (dns block)
- Triggering command: /usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/router/router/node_modules/.pnpm/nx@22.6.5_@swc-node+register@1.11.1_@emnapi+core@1.10.0_@emnapi+runtime@1.10.0_@swc+cor_f8cf112faadbfcc2e1461352f7817c81/node_modules/nx/src/project-graph/plugins/isolation/plugin-worker /tmp/plugin5357-2-363.557867.sock /home/REDACTED/work/router/router/node_modules/.pnpm/nx@22.6.5_@swc-node+register@1.11.1_@emnapi+core@1.10.0_@emnapi+runtime@1.10.0_@swc+cor_f8cf112faadbfcc2e1461352f7817c81/node_modules/nx/src/plugins/project-json/build-nodes/project-json (dns block)
- Triggering command: /usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/router/router/node_modules/.pnpm/nx@22.6.5_@swc-node+register@1.11.1_@emnapi+core@1.10.0_@emnapi+runtime@1.10.0_@swc+cor_f8cf112faadbfcc2e1461352f7817c81/node_modules/nx/src/project-graph/plugins/isolation/plugin-worker /tmp/plugin5357-3-370.280252.sock ./scripts/nx/playwright-plugin.ts (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Agent-Logs-Url: https://github.com/TanStack/router/sessions/aae41f53-16ad-426b-a9bb-36e4d8c9ffcf Co-authored-by: birkskyum <74932975+birkskyum@users.noreply.github.com>

birkskyum · 2026-04-26T00:28:48Z

@copilot rename the route from "routes/mre-data-only.tsx" to something more descriptive (don't include MRE, because all routes are practively mre's)

codspeed-hq · 2026-04-26T00:34:24Z

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 1 skipped benchmark¹

_{Comparing copilot/fix-hydration-regression-for-ssr (3ff8326) with main (aebf426)²}

1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩
No successful run was found on main (65874cd) during the generation of this report, so aebf426 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Agent-Logs-Url: https://github.com/TanStack/router/sessions/0a1fcc3c-48db-4f47-b20b-72dee8d1ff44 Co-authored-by: birkskyum <74932975+birkskyum@users.noreply.github.com>

Copilot · 2026-04-26T00:36:36Z

@copilot rename the route from "routes/mre-data-only.tsx" to something more descriptive (don't include MRE, because all routes are practively mre's)

Renamed the route to data-only-pending-component and updated the test plus generated route tree in c2c2641. No UI changed here, so there isn’t a meaningful screenshot to attach.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

cloud.nx.app
- Triggering command: /usr/local/bin/node node ./node_modules/.bin/../nx/bin/nx.js run tanstack-solid-start-e2e-selective-ssr:build --outputStyle=stream --skipRemoteCache (dns block)
- Triggering command: /usr/local/bin/node node ./node_modules/.bin/../nx/bin/nx.js run tanstack-solid-start-e2e-selective-ssr:test:e2e --outputStyle=stream --skipRemoteCache -- tests/pending-component-hydration.spec.ts tart-e2e-selectinode ream e git conf�� --local pull.rebase in/sh (dns block)
- Triggering command: /usr/local/bin/node node ./node_modules/.bin/../nx/bin/nx.js run tanstack-solid-start-e2e-selective-ssr:test:e2e --outputStyle=stream --skipRemoteCache -- tests/pending-component-hydration.spec.ts (dns block)
sparrow.cloudflare.com
- Triggering command: /usr/local/bin/node /usr/local/bin/node --no-warnings --experimental-vm-modules /home/REDACTED/work/router/router/node_modules/.pnpm/wrangler@4.75.0/node_modules/wrangler/wrangler-dist/cli.js types (dns block)
www.google-analytics.com
- Triggering command: /usr/local/bin/node node ./node_modules/.bin/../nx/bin/nx.js run tanstack-solid-start-e2e-selective-ssr:build --outputStyle=stream --skipRemoteCache (dns block)
- Triggering command: /usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/router/router/node_modules/.pnpm/nx@22.6.5_@swc-node+register@1.11.1_@emnapi+core@1.10.0_@emnapi+runtime@1.10.0_@swc+cor_f8cf112faadbfcc2e1461352f7817c81/node_modules/nx/src/project-graph/plugins/isolation/plugin-worker /tmp/plugin4333-2-362.046595.sock /home/REDACTED/work/router/router/node_modules/.pnpm/nx@22.6.5_@swc-node+register@1.11.1_@emnapi+core@1.10.0_@emnapi+runtime@1.10.0_@swc+cor_f8cf112faadbfcc2e1461352f7817c81/node_modules/nx/src/plugins/project-json/build-nodes/project-json (dns block)
- Triggering command: /usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/router/router/node_modules/.pnpm/nx@22.6.5_@swc-node+register@1.11.1_@emnapi+core@1.10.0_@emnapi+runtime@1.10.0_@swc+cor_f8cf112faadbfcc2e1461352f7817c81/node_modules/nx/src/project-graph/plugins/isolation/plugin-worker /tmp/plugin4333-3-366.705703.sock ./scripts/nx/playwright-plugin.ts (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

nx-cloud

Nx Cloud has identified a flaky task in your failed CI:

🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.

View detailed reasoning in Nx Cloud ↗

_{🎓 Learn more about Self-Healing CI on nx.dev}

Initial plan

564aadf

Copilot AI assigned Copilot and brenelz Apr 25, 2026

Copilot started work on behalf of brenelz April 25, 2026 23:23 View session

Copilot AI linked an issue Apr 25, 2026 that may be closed by this pull request

Solid: ssr='data-only' + pendingComponent element causes hydration mismatch / template is not a function #7085

Closed

Copilot AI requested a review from brenelz April 25, 2026 23:49

Copilot stopped work on behalf of brenelz due to an error April 25, 2026 23:49
The session was cancelled by the user.

Copilot started work on behalf of brenelz April 25, 2026 23:52 View session

Copilot finished work on behalf of brenelz April 25, 2026 23:52

fix: avoid duplicate suspense fallback for solid data-only ssr

c6a2ba5

github-actions Bot added the package: solid-router label Apr 26, 2026

brenelz marked this pull request as ready for review April 26, 2026 00:17

brenelz changed the title ~~[WIP] Fix hydration mismatch for ssr='data-only' with pendingComponent~~ Fix hydration mismatch for ssr='data-only' with pendingComponent Apr 26, 2026

brenelz mentioned this pull request Apr 26, 2026

[codex] Add Solid Start pending hydration regression test #7086

Closed

birkskyum reviewed Apr 26, 2026

View reviewed changes

Copilot started work on behalf of birkskyum April 26, 2026 00:20 View session

refactor: share browser error collection helper

92177e3

Agent-Logs-Url: https://github.com/TanStack/router/sessions/aae41f53-16ad-426b-a9bb-36e4d8c9ffcf Co-authored-by: birkskyum <74932975+birkskyum@users.noreply.github.com>

Copilot finished work on behalf of birkskyum April 26, 2026 00:27

Copilot AI requested a review from birkskyum April 26, 2026 00:27

Copilot started work on behalf of birkskyum April 26, 2026 00:27 View session

Copilot finished work on behalf of birkskyum April 26, 2026 00:30

Copilot started work on behalf of birkskyum April 26, 2026 00:30 View session

rename selective SSR regression route

c2c2641

Agent-Logs-Url: https://github.com/TanStack/router/sessions/0a1fcc3c-48db-4f47-b20b-72dee8d1ff44 Co-authored-by: birkskyum <74932975+birkskyum@users.noreply.github.com>

Copilot finished work on behalf of birkskyum April 26, 2026 00:37

ci: apply automated fixes

9273ab9

This comment was marked as outdated.

Sign in to view

nx-cloud Bot added 2 commits April 26, 2026 00:55

ci: apply automated fixes [Self-Healing CI Rerun]

e36caf4

ci: apply automated fixes [Self-Healing CI Rerun]

8ae1bc0

This comment was marked as outdated.

Sign in to view

ci: apply automated fixes [Self-Healing CI Rerun]

e22c3b5

This comment was marked as outdated.

Sign in to view

changeset

3ff8326

birkskyum merged commit 944b155 into main Apr 26, 2026
12 of 13 checks passed

birkskyum deleted the copilot/fix-hydration-regression-for-ssr branch April 26, 2026 02:43

nx-cloud Bot reviewed Apr 26, 2026

View reviewed changes

Uh oh!

Conversation

Copilot AI commented Apr 25, 2026 • edited by birkskyum Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brenelz commented Apr 25, 2026

Uh oh!

nx-cloud Bot commented Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Changeset Version Preview

🟩 Patch bumps

Uh oh!

pkg-pr-new Bot commented Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Size Benchmarks

Uh oh!

birkskyum Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

birkskyum Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

birkskyum commented Apr 26, 2026

Uh oh!

Copilot AI commented Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

birkskyum commented Apr 26, 2026

Uh oh!

codspeed-hq Bot commented Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Copilot AI commented Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

nx-cloud Bot left a comment

Choose a reason for hiding this comment

Nx Cloud has identified a flaky task in your failed CI:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 25, 2026 •

edited by birkskyum

Loading

nx-cloud Bot commented Apr 26, 2026 •

edited

Loading

github-actions Bot commented Apr 26, 2026 •

edited

Loading

pkg-pr-new Bot commented Apr 26, 2026 •

edited

Loading

github-actions Bot commented Apr 26, 2026 •

edited

Loading

birkskyum Apr 26, 2026 •

edited

Loading

Copilot AI commented Apr 26, 2026 •

edited

Loading

codspeed-hq Bot commented Apr 26, 2026 •

edited

Loading

Copilot AI commented Apr 26, 2026 •

edited

Loading