bench(memory): prefix client and server benchmark names by Sheraff · Pull Request #7743 · TanStack/router

Sheraff · 2026-07-03T19:52:11Z

Summary

Prefix client memory benchmark workload labels with mem client
Prefix server memory benchmark workload labels with mem server

Tests

CI=1 NX_DAEMON=false pnpm nx run @benchmarks/memory-client:test:types --outputStyle=stream --skipRemoteCache
CI=1 NX_DAEMON=false pnpm nx run @benchmarks/memory-server:test:types --outputStyle=stream --skipRemoteCache

Summary by CodeRabbit

Chores
- Updated benchmark labels across multiple memory test scenarios to clearly distinguish client and server workloads.
- Standardized several scenario names with client or server prefixes, including navigation, loader data retention, mount/unmount, request churn, error paths, and streaming/serialization cases.
- Refined one server scenario label to better reflect its workload naming.

coderabbitai · 2026-07-03T19:53:13Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8127a0c1-f9ee-435b-b8ff-6e0e8592c70e

📥 Commits

Reviewing files that changed from the base of the PR and between d644dbb and ac8eb04.

📒 Files selected for processing (13)

benchmarks/memory/client/scenarios/interrupted-navigations/shared.ts
benchmarks/memory/client/scenarios/loader-data-retention/shared.ts
benchmarks/memory/client/scenarios/mount-unmount/shared.ts
benchmarks/memory/client/scenarios/navigation-churn/shared.ts
benchmarks/memory/client/scenarios/preload-churn/shared.ts
benchmarks/memory/client/scenarios/unique-location-churn/shared.ts
benchmarks/memory/server/scenarios/aborted-requests/shared.ts
benchmarks/memory/server/scenarios/error-paths/shared.ts
benchmarks/memory/server/scenarios/peak-large-page/shared.ts
benchmarks/memory/server/scenarios/request-churn/shared.ts
benchmarks/memory/server/scenarios/serialization-payload/shared.ts
benchmarks/memory/server/scenarios/server-fn-churn/shared.ts
benchmarks/memory/server/scenarios/streaming-peak/shared.ts

📝 Walkthrough

Walkthrough

This PR updates the display name strings in memory benchmark scenario files under benchmarks/memory/client and benchmarks/memory/server, prefixing them with "client" or "server" respectively. No logic, control flow, or exported API signatures are changed.

Changes

Benchmark label prefix updates

Layer / File(s)	Summary
Client scenario labels `benchmarks/memory/client/scenarios/interrupted-navigations/shared.ts`, `.../loader-data-retention/shared.ts`, `.../mount-unmount/shared.ts`, `.../navigation-churn/shared.ts`, `.../preload-churn/shared.ts`, `.../unique-location-churn/shared.ts`	Each scenario's returned `name` string is updated to add a "client" prefix (e.g., "mem client mount-unmount (...)").
Server scenario labels `benchmarks/memory/server/scenarios/aborted-requests/shared.ts`, `.../error-paths/shared.ts`, `.../peak-large-page/shared.ts`, `.../request-churn/shared.ts`, `.../serialization-payload/shared.ts`, `.../server-fn-churn/shared.ts`, `.../streaming-peak/shared.ts`	Each scenario's workload `name` string(s) are updated to add a "server" prefix (e.g., "mem server request-churn (...)").

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: schiller-manuel

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: prefixing client and server benchmark names.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/memory-benchmark-prefixes

_{Comment @coderabbitai help to get the list of available commands.}

nx-cloud · 2026-07-03T19:55:05Z

View your CI Pipeline Execution ↗ for commit ac8eb04

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	✅ Succeeded	3m 38s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2m 20s	View ↗

☁️ Nx Cloud last updated this comment at 2026-07-03 19:59:56 UTC

github-actions · 2026-07-03T19:55:40Z

Bundle Size Benchmarks

Commit: 3a0cba23ba9e
Measured at: 2026-07-03T19:54:58.769Z
Baseline source: history:d644dbb5c226
Dashboard: bundle-size history

Scenario	Current (gzip)	Delta vs baseline	Initial gzip	Raw	Brotli	Trend
`react-router.minimal`	87.37 KiB	0 B (0.00%)	87.24 KiB	273.88 KiB	75.99 KiB	▁▁▄▄▄▄█████
`react-router.full`	91.10 KiB	0 B (0.00%)	90.96 KiB	285.78 KiB	79.15 KiB	▁▁▅▅▅▅█████
`solid-router.minimal`	35.56 KiB	0 B (0.00%)	35.44 KiB	106.08 KiB	32.05 KiB	▁▁▅▅▅▅█████
`solid-router.full`	40.61 KiB	0 B (0.00%)	40.49 KiB	121.30 KiB	36.54 KiB	▁▁▆▆▆▆█████
`vue-router.minimal`	53.07 KiB	0 B (0.00%)	52.94 KiB	150.12 KiB	47.70 KiB	▁▁▄▄▄▄█████
`vue-router.full`	59.03 KiB	0 B (0.00%)	58.90 KiB	168.88 KiB	52.93 KiB	▁▁▄▄▄▄█████
`react-start.minimal`	102.03 KiB	0 B (0.00%)	101.89 KiB	322.31 KiB	88.32 KiB	▁▁▃▃▃▆█████
`react-start.deferred-hydration`	102.76 KiB	0 B (0.00%)	101.91 KiB	323.69 KiB	88.91 KiB	▁▁▄▄▄▆█████
`react-start.full`	105.45 KiB	0 B (0.00%)	105.31 KiB	332.24 KiB	91.23 KiB	▁▁▃▃▃▅█████
`react-start.rsbuild.minimal`	99.74 KiB	0 B (0.00%)	99.57 KiB	316.74 KiB	85.81 KiB	▁▁▃▂▂▅█████
`react-start.rsbuild.minimal-iife`	100.14 KiB	0 B (0.00%)	99.98 KiB	317.67 KiB	86.21 KiB	▁▁▃▂▂▅█████
`react-start.rsbuild.full`	102.96 KiB	0 B (0.00%)	102.79 KiB	326.79 KiB	88.60 KiB	▁▁▃▃▃▅█████
`solid-start.minimal`	49.71 KiB	0 B (0.00%)	49.58 KiB	152.25 KiB	43.88 KiB	▁▁▃▃▃▆█████
`solid-start.deferred-hydration`	52.97 KiB	0 B (0.00%)	49.64 KiB	160.29 KiB	46.85 KiB	▁▁▃▃▃▅█████
`solid-start.full`	55.51 KiB	0 B (0.00%)	55.38 KiB	169.30 KiB	48.97 KiB	▁▁▄▄▄▆█████
`vue-start.minimal`	71.13 KiB	0 B (0.00%)	71.00 KiB	207.37 KiB	63.03 KiB	▁▁▄▄▄▇█████
`vue-start.full`	75.13 KiB	0 B (0.00%)	75.00 KiB	220.01 KiB	66.37 KiB	▁▁▄▄▄▆█████

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

github-actions · 2026-07-03T19:56:09Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-07-03T19:58:46Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7743

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7743

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7743

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7743

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7743

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7743

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7743

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7743

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7743

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7743

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7743

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7743

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7743

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7743

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7743

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7743

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7743

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7743

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7743

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7743

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7743

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7743

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7743

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7743

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7743

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7743

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7743

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7743

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7743

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7743

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7743

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7743

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7743

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7743

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7743

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7743

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7743

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7743

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7743

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7743

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7743

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7743

commit: ac8eb04

codspeed-hq · 2026-07-03T20:08:13Z

Merging this PR will not alter performance

✅ 132 untouched benchmarks
🆕 48 new benchmarks

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
🆕	Memory	`mem server aborted-requests (vue)`	N/A	449.9 KB	N/A
🆕	Memory	`mem server error-paths error (vue)`	N/A	889.5 KB	N/A
🆕	Memory	`mem server error-paths not-found (vue)`	N/A	383.6 KB	N/A
🆕	Memory	`mem server error-paths redirect (vue)`	N/A	712.1 KB	N/A
🆕	Memory	`mem server error-paths unmatched (vue)`	N/A	2.1 MB	N/A
🆕	Memory	`mem server peak-large-page (vue)`	N/A	710.1 KB	N/A
🆕	Memory	`mem server request-churn (vue)`	N/A	783.7 KB	N/A
🆕	Memory	`mem server serialization-payload (vue)`	N/A	3.5 MB	N/A
🆕	Memory	`mem server server-fn-churn (vue)`	N/A	263.1 KB	N/A
🆕	Memory	`mem server streaming-peak chunked (vue)`	N/A	11.1 MB	N/A
🆕	Memory	`mem server aborted-requests (solid)`	N/A	936.8 KB	N/A
🆕	Memory	`mem server error-paths error (solid)`	N/A	913.8 KB	N/A
🆕	Memory	`mem server error-paths not-found (solid)`	N/A	410.3 KB	N/A
🆕	Memory	`mem server error-paths redirect (solid)`	N/A	441.2 KB	N/A
🆕	Memory	`mem server error-paths unmatched (solid)`	N/A	470.2 KB	N/A
🆕	Memory	`mem server peak-large-page (solid)`	N/A	795 KB	N/A
🆕	Memory	`mem server request-churn (solid)`	N/A	417.6 KB	N/A
🆕	Memory	`mem server serialization-payload (solid)`	N/A	3.5 MB	N/A
🆕	Memory	`mem server server-fn-churn (solid)`	N/A	268.7 KB	N/A
🆕	Memory	`mem server streaming-peak chunked (solid)`	N/A	30.3 MB	N/A
...	...	...	...	...	...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

_{Comparing chore/memory-benchmark-prefixes (ac8eb04) with main (d644dbb)}

bench(memory): prefix client and server benchmark names

ac8eb04

Sheraff merged commit a3e24c3 into main Jul 3, 2026
26 checks passed

Sheraff deleted the chore/memory-benchmark-prefixes branch July 3, 2026 20:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

bench(memory): prefix client and server benchmark names#7743

bench(memory): prefix client and server benchmark names#7743
Sheraff merged 1 commit into
mainfrom
chore/memory-benchmark-prefixes

Sheraff commented Jul 3, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 3, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

nx-cloud Bot commented Jul 3, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

pkg-pr-new Bot commented Jul 3, 2026

Uh oh!

codspeed-hq Bot commented Jul 3, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

Sheraff commented Jul 3, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Tests

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

nx-cloud Bot commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 3, 2026

Bundle Size Benchmarks

Uh oh!

github-actions Bot commented Jul 3, 2026

🚀 Changeset Version Preview

Uh oh!

pkg-pr-new Bot commented Jul 3, 2026

Uh oh!

codspeed-hq Bot commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Performance Changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Sheraff commented Jul 3, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 3, 2026 •

edited

Loading

nx-cloud Bot commented Jul 3, 2026 •

edited

Loading

codspeed-hq Bot commented Jul 3, 2026 •

edited

Loading