Skip to content

fix: use relative path for srvx static files#7799

Merged
schiller-manuel merged 1 commit into
TanStack:mainfrom
flofehrenbacher:patch-1
Jul 13, 2026
Merged

fix: use relative path for srvx static files#7799
schiller-manuel merged 1 commit into
TanStack:mainfrom
flofehrenbacher:patch-1

Conversation

@flofehrenbacher

@flofehrenbacher flofehrenbacher commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Running srvx --prod -s dist/client dist/server/index.js didn't work because srvx@0.11.22 always responded with

srvx 0.11.21 · node 24.15.0 · prod
◆ Server handler: ./dist/server/index.js
◇ Static files:   (create public/ dir)

When changing to srvx --prod -s ../client dist/server/index.js the output is

srvx 0.11.21 · node 24.15.0 · prod
◆ Server handler: ./dist/server/index.js
◇ Static files:   ./dist/client/

and everything works.

Summary by CodeRabbit

  • Documentation
    • Updated Rsbuild deployment instructions to serve the client files from the correct directory when using srvx.
    • Retained the server entry configuration for dist/server/index.js.

@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2d8251f0-514f-43e3-bffb-f84211af39ca

📥 Commits

Reviewing files that changed from the base of the PR and between a3e24c3 and 9242b64.

📒 Files selected for processing (1)
  • docs/start/framework/react/guide/hosting.md

📝 Walkthrough

Walkthrough

The Rsbuild deployment example updates its srvx start command to serve the client directory from ../client, while retaining dist/server/index.js as the server entry.

Changes

Rsbuild hosting

Layer / File(s) Summary
Update srvx asset path
docs/start/framework/react/guide/hosting.md
The start command now serves static assets from ../client instead of dist/client and continues targeting dist/server/index.js.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: switching srvx static files to a relative path.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@schiller-manuel schiller-manuel merged commit 4d4171f into TanStack:main Jul 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants