Skip to content

Upgrade solidjs beta 20#7850

Merged
birkskyum merged 2 commits into
solid-router-v2-prefrom
upgrade-solidjs-beta-20
Jul 18, 2026
Merged

Upgrade solidjs beta 20#7850
birkskyum merged 2 commits into
solid-router-v2-prefrom
upgrade-solidjs-beta-20

Conversation

@brenelz

@brenelz brenelz commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Upgrades the Solid v2 toolchain:

  • solid-js / @solidjs/web 2.0.0-beta.192.0.0-beta.20 (exact pins across packages, examples, e2e apps, and benchmarks)
  • vite-plugin-solid ^3.0.0-next.11^3.0.0-next.13
  • babel-preset-solid lockstep fixes: the quickstart-webpack example's direct pin was stuck on beta.18, and @rsbuild/plugin-solid's lockfile resolution was also stale at beta.18 (pnpm keeps in-range transitive resolutions); both now resolve beta.20 so compiler and runtime stay in lockstep everywhere
  • changeset patch-bumping the six @tanstack/solid-* packages

Native JSX compiler

vite-plugin-solid@3.0.0-next.13 switches the default backend from babel-preset-solid to the new native @dom-expressions/compiler. The repo now runs on that default. The native milestone's one unsupported construct we used — a fragment passed as a component's child (dom mode only, fails with "Only text and expression component children are implemented in the AST-native milestone") — occurred exactly once, in solid-router's ClientOnly, where the <>{props.children}</> wrapper was redundant anyway and is now just {props.children}.

Verification

  • packages/solid-router test:unit: 46 files / 814 tests (client) + 2 (server mode) passing
  • e2e/solid-start/basic: pnpm build + test:e2e:local — 80 passed, 4 skipped
  • all 1353 solid .tsx/.jsx files in the repo compiled directly through @dom-expressions/compiler in both dom and ssr modes: zero failures (harness validated by reproducing the ClientOnly failure on the pre-fix source)

🤖 Generated with Claude Code

brenelz and others added 2 commits July 18, 2026 10:32
Bumps solid-js and @solidjs/web from 2.0.0-beta.19 to 2.0.0-beta.20 and
vite-plugin-solid from 3.0.0-next.11 to 3.0.0-next.13 across packages,
examples, e2e apps, and benchmarks.

vite-plugin-solid 3.0.0-next.13 defaults to the new native JSX backend
(@dom-expressions/compiler), which is an incomplete milestone build that
cannot compile components with element children yet ("Only text and
expression component children are implemented in the AST-native
milestone"). Every vite-plugin-solid call site now passes
compiler: 'babel' to keep the babel-preset-solid pipeline until the
native compiler matures.

Also fixes two pins that had gone stale: the quickstart-webpack example's
direct babel-preset-solid pin (stuck on beta.18) and
@rsbuild/plugin-solid's babel-preset-solid lockfile resolution (also
beta.18), so the compiler and runtime are in lockstep everywhere.

Verified with solid-router test:unit (client + server modes) and
e2e/solid-start/basic (pnpm build + test:e2e:local).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Removes the compiler: 'babel' escape hatch from all vite-plugin-solid
call sites, returning to next.13's default native backend
(@dom-expressions/compiler).

The native compiler's only unimplemented construct that this repo used
was a fragment passed as a component's child (dom mode only). The single
instance — the redundant <>{props.children}</> wrapper in solid-router's
ClientOnly — is removed; props.children is a valid JSX child on its own.

Verified: solid-router test:unit (client + server), e2e/solid-start/basic
(pnpm build + test:e2e:local), and a direct scan of all 1353 solid
.tsx/.jsx files in the repo through @dom-expressions/compiler in both
dom and ssr modes with zero failures.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8531ce5a-8e6c-45ae-a08f-486fca64e325

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch upgrade-solidjs-beta-20

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit b10aeee

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 13m 59s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 16s View ↗

☁️ Nx Cloud last updated this comment at 2026-07-18 16:00:39 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

6 package(s) bumped directly, 0 bumped as dependents.

🟩 Patch bumps

Package Version Reason
@tanstack/solid-router 2.0.0-beta.24 → 2.0.0-beta.25 Changeset
@tanstack/solid-router-devtools 2.0.0-beta.19 → 2.0.0-beta.20 Changeset
@tanstack/solid-router-ssr-query 2.0.0-beta.25 → 2.0.0-beta.26 Changeset
@tanstack/solid-start 2.0.0-beta.25 → 2.0.0-beta.26 Changeset
@tanstack/solid-start-client 2.0.0-beta.24 → 2.0.0-beta.25 Changeset
@tanstack/solid-start-server 2.0.0-beta.24 → 2.0.0-beta.25 Changeset

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 5061204f40a6
  • Measured at: 2026-07-18T15:47:47.354Z
  • Baseline source: history:62a191baa068
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Initial gzip Raw Brotli Trend
react-router.minimal 87.37 KiB +26 B (+0.03%) 87.24 KiB 273.88 KiB 75.99 KiB ███▁▁▁▁▁▁▁▁█
react-router.full 91.10 KiB +42 B (+0.05%) 90.96 KiB 285.78 KiB 79.15 KiB ███▁▁▁▁▁▁▁▁█
solid-router.minimal 40.90 KiB +5.37 KiB (+15.12%) 40.77 KiB 119.43 KiB 36.91 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-router.full 45.92 KiB +5.34 KiB (+13.16%) 45.80 KiB 134.92 KiB 41.34 KiB ▁▁▁▁▁▁▁▁▁▁▁█
vue-router.minimal 53.07 KiB +69 B (+0.13%) 52.94 KiB 150.12 KiB 47.70 KiB ███▁▁▁▁▁▁▁▁█
vue-router.full 59.03 KiB +99 B (+0.16%) 58.90 KiB 168.88 KiB 52.93 KiB ███▁▁▁▁▁▁▁▁█
react-start.minimal 102.03 KiB +41 B (+0.04%) 101.89 KiB 322.31 KiB 88.32 KiB ███▁▁▁▁▁▁▁▁█
react-start.deferred-hydration 102.76 KiB +40 B (+0.04%) 101.91 KiB 323.69 KiB 88.91 KiB ███▁▁▁▁▁▁▁▁█
react-start.full 105.45 KiB +87 B (+0.08%) 105.31 KiB 332.24 KiB 91.23 KiB ███▁▁▁▁▁▁▁▁█
react-start.rsbuild.minimal 99.74 KiB +64 B (+0.06%) 99.57 KiB 316.74 KiB 85.81 KiB ███▁▁▁▁▁▁▁▁█
react-start.rsbuild.minimal-iife 100.14 KiB +67 B (+0.07%) 99.98 KiB 317.67 KiB 86.21 KiB ███▁▁▁▁▁▁▁▁█
react-start.rsbuild.full 102.96 KiB +70 B (+0.07%) 102.79 KiB 326.79 KiB 88.60 KiB ███▁▁▁▁▁▁▁▁█
solid-start.minimal 67.05 KiB +17.44 KiB (+35.15%) 66.92 KiB 199.72 KiB 59.60 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-start.deferred-hydration 70.91 KiB +18.04 KiB (+34.12%) 67.42 KiB 208.45 KiB 63.21 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-start.full 70.96 KiB +15.54 KiB (+28.03%) 70.83 KiB 211.30 KiB 62.96 KiB ▁▁▁▁▁▁▁▁▁▁▁█
vue-start.minimal 71.13 KiB +104 B (+0.14%) 71.00 KiB 207.37 KiB 63.03 KiB ███▁▁▁▁▁▁▁▁█
vue-start.full 75.13 KiB +101 B (+0.13%) 75.00 KiB 220.01 KiB 66.37 KiB ███▁▁▁▁▁▁▁▁█

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-new Bot commented Jul 18, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7850

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7850

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7850

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7850

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7850

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7850

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7850

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7850

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7850

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7850

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7850

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7850

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7850

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7850

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7850

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7850

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7850

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7850

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7850

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7850

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7850

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7850

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7850

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7850

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7850

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7850

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7850

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7850

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7850

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7850

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7850

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7850

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7850

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7850

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7850

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7850

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7850

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7850

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7850

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7850

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7850

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7850

commit: b10aeee

@codspeed-hq

codspeed-hq Bot commented Jul 18, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 56.17%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 6 improved benchmarks
🆕 173 new benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation ssr request loop (react) 330.5 ms 77.9 ms ×4.2
Simulation client-side navigation loop (solid) 72.6 ms 43.7 ms +66.43%
Simulation ssr request loop (vue) 420.3 ms 284 ms +47.97%
Simulation ssr request loop (solid) 174.6 ms 151.3 ms +15.43%
Simulation client-side navigation loop (react) 56.3 ms 50.3 ms +11.81%
Simulation client-side navigation loop (vue) 83 ms 77.2 ms +7.58%
🆕 Simulation ssr not-found (vue) N/A 169.5 ms N/A
🆕 Simulation ssr redirect (vue) N/A 68.2 ms N/A
🆕 Simulation ssr head (vue) N/A 326.8 ms N/A
🆕 Simulation ssr loaders (vue) N/A 136.6 ms N/A
🆕 Simulation ssr selective (vue) N/A 139.8 ms N/A
🆕 Simulation ssr server-fn GET (vue) N/A 74.5 ms N/A
🆕 Simulation ssr server-fn POST (vue) N/A 71.3 ms N/A
🆕 Simulation ssr server-route middleware (vue) N/A 63.3 ms N/A
🆕 Simulation ssr server-route (vue) N/A 60.8 ms N/A
🆕 Simulation ssr streaming deferred (vue) N/A 105 ms N/A
🆕 Simulation ssr assets inline-css cdn (vue) N/A 188.4 ms N/A
🆕 Simulation ssr assets linked-css control (vue) N/A 215.7 ms N/A
🆕 Simulation ssr before-load chain (vue) N/A 184.4 ms N/A
🆕 Simulation ssr control-flow error 500 (vue) N/A 197.9 ms N/A
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing upgrade-solidjs-beta-20 (b10aeee) with solid-router-v2-pre (67a9040)1

Open in CodSpeed

Footnotes

  1. No successful run was found on solid-router-v2-pre (7a0cf36) during the generation of this report, so 67a9040 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@birkskyum
birkskyum merged commit 62f3b26 into solid-router-v2-pre Jul 18, 2026
26 checks passed
@birkskyum
birkskyum deleted the upgrade-solidjs-beta-20 branch July 18, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants