Skip to content

Upgrade solidjs beta 25#7888

Merged
birkskyum merged 2 commits into
solid-router-v2-prefrom
upgrade-solidjs-beta-25
Jul 23, 2026
Merged

Upgrade solidjs beta 25#7888
birkskyum merged 2 commits into
solid-router-v2-prefrom
upgrade-solidjs-beta-25

Conversation

@brenelz

@brenelz brenelz commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Upgrades solid-js, @solidjs/web, and babel-preset-solid to 2.0.0-beta.25 across all packages, examples, and e2e apps, and vite-plugin-solid to ^3.0.0-next.16 (peer-requires solid-js >= beta.25, ships @dom-expressions/compiler 0.50.0-next.29).

Verified locally on the combined state:

  • @tanstack/solid-router test:unit: 814 client + 2 server tests pass, no type errors
  • e2e/solid-start/basic: build + 80 e2e tests pass
  • e2e/solid-router/basic-file-based: build + 120 e2e tests pass

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2f7a08c9-bbe6-4a44-8d14-d8c9c3f9e902

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch upgrade-solidjs-beta-25

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 4e851eb

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 15m 5s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 46s View ↗

☁️ Nx Cloud last updated this comment at 2026-07-23 20:42:41 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

6 package(s) bumped directly, 0 bumped as dependents.

🟩 Patch bumps

Package Version Reason
@tanstack/solid-router 2.0.0-beta.26 → 2.0.0-beta.27 Changeset
@tanstack/solid-router-devtools 2.0.0-beta.21 → 2.0.0-beta.22 Changeset
@tanstack/solid-router-ssr-query 2.0.0-beta.27 → 2.0.0-beta.28 Changeset
@tanstack/solid-start 2.0.0-beta.27 → 2.0.0-beta.28 Changeset
@tanstack/solid-start-client 2.0.0-beta.26 → 2.0.0-beta.27 Changeset
@tanstack/solid-start-server 2.0.0-beta.26 → 2.0.0-beta.27 Changeset

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: c0a8abab3333
  • Measured at: 2026-07-23T20:27:54.610Z
  • Baseline source: history:3a5575627d46
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Initial gzip Raw Brotli Trend
react-router.minimal 87.37 KiB +26 B (+0.03%) 87.24 KiB 273.88 KiB 75.99 KiB ▁▁▁▁▁▁▁▁▁▁▁█
react-router.full 91.10 KiB +42 B (+0.05%) 90.96 KiB 285.78 KiB 79.15 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-router.minimal 41.05 KiB +5.53 KiB (+15.56%) 40.93 KiB 119.99 KiB 37.04 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-router.full 46.16 KiB +5.57 KiB (+13.73%) 46.03 KiB 135.64 KiB 41.57 KiB ▁▁▁▁▁▁▁▁▁▁▁█
vue-router.minimal 53.07 KiB +69 B (+0.13%) 52.94 KiB 150.12 KiB 47.70 KiB ▁▁▁▁▁▁▁▁▁▁▁█
vue-router.full 59.03 KiB +99 B (+0.16%) 58.90 KiB 168.88 KiB 52.93 KiB ▁▁▁▁▁▁▁▁▁▁▁█
react-start.minimal 102.03 KiB +41 B (+0.04%) 101.89 KiB 322.31 KiB 88.32 KiB ▁▁▁▁▁▁▁▁▁▁▁█
react-start.deferred-hydration 102.76 KiB +40 B (+0.04%) 101.91 KiB 323.69 KiB 88.91 KiB ▁▁▁▁▁▁▁▁▁▁▁█
react-start.full 105.45 KiB +87 B (+0.08%) 105.31 KiB 332.24 KiB 91.23 KiB ▁▁▁▁▁▁▁▁▁▁▁█
react-start.rsbuild.minimal 99.74 KiB +64 B (+0.06%) 99.57 KiB 316.74 KiB 85.81 KiB ▁▁▁▁▁▁▁▁▁▁▁█
react-start.rsbuild.minimal-iife 100.14 KiB +67 B (+0.07%) 99.98 KiB 317.67 KiB 86.21 KiB ▁▁▁▁▁▁▁▁▁▁▁█
react-start.rsbuild.full 102.96 KiB +70 B (+0.07%) 102.79 KiB 326.79 KiB 88.60 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-start.minimal 68.29 KiB +18.68 KiB (+37.65%) 68.16 KiB 203.64 KiB 60.67 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-start.deferred-hydration 72.16 KiB +19.29 KiB (+36.49%) 68.67 KiB 212.38 KiB 64.24 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-start.full 72.19 KiB +16.77 KiB (+30.26%) 72.06 KiB 215.22 KiB 63.96 KiB ▁▁▁▁▁▁▁▁▁▁▁█
vue-start.minimal 71.13 KiB +104 B (+0.14%) 71.00 KiB 207.37 KiB 63.03 KiB ▁▁▁▁▁▁▁▁▁▁▁█
vue-start.full 75.13 KiB +101 B (+0.13%) 75.00 KiB 220.01 KiB 66.37 KiB ▁▁▁▁▁▁▁▁▁▁▁█

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-new Bot commented Jul 23, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7888

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7888

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7888

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7888

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7888

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7888

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7888

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7888

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7888

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7888

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7888

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7888

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7888

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7888

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7888

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7888

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7888

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7888

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7888

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7888

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7888

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7888

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7888

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7888

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7888

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7888

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7888

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7888

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7888

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7888

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7888

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7888

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7888

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7888

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7888

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7888

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7888

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7888

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7888

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7888

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7888

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7888

commit: 4e851eb

@codspeed-hq

codspeed-hq Bot commented Jul 23, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 58.22%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 6 improved benchmarks
🆕 173 new benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation ssr request loop (react) 330.5 ms 77.9 ms ×4.2
Simulation client-side navigation loop (solid) 72.6 ms 43 ms +69.13%
Simulation ssr request loop (vue) 420.3 ms 284.2 ms +47.87%
Simulation ssr request loop (solid) 174.6 ms 142.3 ms +22.73%
Simulation client-side navigation loop (react) 56.3 ms 50.3 ms +11.85%
Simulation client-side navigation loop (vue) 83 ms 77.1 ms +7.72%
🆕 Memory mem client interrupted-navigations (vue) N/A 865.2 KB N/A
🆕 Memory mem client loader-data-retention (vue) N/A 595.7 KB N/A
🆕 Memory mem client mount-unmount (vue) N/A 839.5 KB N/A
🆕 Memory mem client navigation-churn (vue) N/A 986.9 KB N/A
🆕 Memory mem client preload-churn (vue) N/A 666 KB N/A
🆕 Memory mem client unique-location-churn (vue) N/A 1.1 MB N/A
🆕 Simulation ssr not-found (vue) N/A 169.5 ms N/A
🆕 Simulation ssr redirect (vue) N/A 68.2 ms N/A
🆕 Simulation ssr head (vue) N/A 326.9 ms N/A
🆕 Simulation ssr loaders (vue) N/A 137 ms N/A
🆕 Simulation ssr selective (vue) N/A 139.8 ms N/A
🆕 Simulation ssr server-fn GET (vue) N/A 74.5 ms N/A
🆕 Simulation ssr server-fn POST (vue) N/A 71.4 ms N/A
🆕 Simulation ssr server-route middleware (vue) N/A 63.3 ms N/A
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing upgrade-solidjs-beta-25 (4e851eb) with solid-router-v2-pre (67a9040)1

Open in CodSpeed

Footnotes

  1. No successful run was found on solid-router-v2-pre (f370e36) during the generation of this report, so 67a9040 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@birkskyum
birkskyum merged commit a7e9835 into solid-router-v2-pre Jul 23, 2026
37 of 38 checks passed
@birkskyum
birkskyum deleted the upgrade-solidjs-beta-25 branch July 23, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants