-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
regression tests #7889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
schiller-manuel
wants to merge
3
commits into
fix-router-core-lane-match-loader
Choose a base branch
from
regression-4614
base: fix-router-core-lane-match-loader
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
regression tests #7889
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
e2e/react-start/basic/src/routes/issue-6221.article.$id.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| import { Link, createFileRoute } from '@tanstack/react-router' | ||
| import { createClientOnlyFn } from '@tanstack/react-start' | ||
|
|
||
| const isAuthed = createClientOnlyFn( | ||
| () => localStorage.getItem('issue-6221-auth') === 'good', | ||
| ) | ||
|
|
||
| const fetchArticle = async (id: string) => { | ||
| await new Promise((resolve) => setTimeout(resolve, 1000)) | ||
| return isAuthed() | ||
| ? { | ||
| title: `Article Title for ${id}`, | ||
| content: `Article content for ${id}`, | ||
| } | ||
| : null | ||
| } | ||
|
|
||
| export const Route = createFileRoute('/issue-6221/article/$id')({ | ||
| ssr: false, | ||
| loader: ({ params }) => fetchArticle(params.id), | ||
| head: ({ loaderData }) => ({ | ||
| meta: [{ title: loaderData?.title ?? 'title n/a' }], | ||
| }), | ||
| component: Article, | ||
| }) | ||
|
|
||
| function Article() { | ||
| const article = Route.useLoaderData() | ||
|
|
||
| return ( | ||
| <div> | ||
| <Link to="/issue-6221/dashboard" data-testid="issue-6221-dashboard-link"> | ||
| Dashboard | ||
| </Link> | ||
| {article ? ( | ||
| <div data-testid="issue-6221-article">{article.content}</div> | ||
| ) : ( | ||
| <div>Article Not Accessible.</div> | ||
| )} | ||
| </div> | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| import { createFileRoute } from '@tanstack/react-router' | ||
|
|
||
| export const Route = createFileRoute('/issue-6221/dashboard')({ | ||
| head: () => ({ meta: [{ title: 'Dashboard' }] }), | ||
| component: () => <div data-testid="issue-6221-dashboard">Dashboard</div>, | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import { expect } from '@playwright/test' | ||
| import { test } from '@tanstack/router-e2e-utils' | ||
| import { isPreview } from './utils/isPreview' | ||
| import { isSpaMode } from './utils/isSpaMode' | ||
|
|
||
| // Ported to React from the regression app in | ||
| // https://github.com/TanStack/router/pull/6222 | ||
| test.skip( | ||
| isSpaMode || isPreview, | ||
| 'head() coverage for an ssr:false route requires the SSR test mode', | ||
| ) | ||
|
|
||
| test('browser back uses fresh loaderData for both the body and head (#6221)', async ({ | ||
| page, | ||
| }) => { | ||
| await page.goto('/') | ||
| await page.evaluate(() => localStorage.setItem('issue-6221-auth', 'good')) | ||
|
|
||
| await page.goto('/issue-6221/article/1') | ||
|
|
||
| await expect(page.getByTestId('issue-6221-article')).toHaveText( | ||
| 'Article content for 1', | ||
| ) | ||
| await expect(page).toHaveTitle('Article Title for 1') | ||
|
|
||
| await page.evaluate(() => localStorage.removeItem('issue-6221-auth')) | ||
| await page.reload() | ||
| await expect(page.getByText('Article Not Accessible.')).toBeVisible() | ||
| await expect(page).toHaveTitle('title n/a') | ||
|
|
||
| await page.evaluate(() => localStorage.setItem('issue-6221-auth', 'good')) | ||
| await page.getByTestId('issue-6221-dashboard-link').click() | ||
| await expect(page.getByTestId('issue-6221-dashboard')).toBeVisible() | ||
| await expect(page).toHaveTitle('Dashboard') | ||
|
|
||
| await page.goBack() | ||
| await expect(page.getByTestId('issue-6221-article')).toHaveText( | ||
| 'Article content for 1', | ||
| ) | ||
| await expect(page).toHaveTitle('Article Title for 1') | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Define one typed global contract for Issue 4614 instrumentation.
The new
globalThis as anycasts erase the payload shape across the route and its regression test. Add a shared TypeScript declaration for these globals and reuse it everywhere.e2e/react-start/selective-ssr/src/routes/__root.tsx#L62-L68: type__issue4614RootBeforeLoads.e2e/react-start/selective-ssr/src/routes/issue-4614.tsx#L6-L10: type__issue4614TargetBeforeLoad.e2e/react-start/selective-ssr/tests/app.spec.ts#L19-L19: read the typed root payload instead of casting toany.📍 Affects 3 files
e2e/react-start/selective-ssr/src/routes/__root.tsx#L62-L68(this comment)e2e/react-start/selective-ssr/src/routes/issue-4614.tsx#L6-L10e2e/react-start/selective-ssr/tests/app.spec.ts#L19-L19🤖 Prompt for AI Agents
Source: Coding guidelines