fix(router-core): handle view transition rejections#7907
Open
David-0x221Eight wants to merge 1 commit into
Open
fix(router-core): handle view transition rejections#7907David-0x221Eight wants to merge 1 commit into
David-0x221Eight wants to merge 1 commit into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough
ChangesView transition error handling
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7906
What changed
ViewTransitionreturned bydocument.startViewTransition().updateCallbackDone,ready, andfinished.AbortErrorand Chromium's hidden-documentInvalidStateError).globalThis.reportError, withconsole.erroras a fallback.Why
The View Transitions API creates lifecycle promises immediately. If the document becomes hidden while a transition is starting, Chromium can reject
readywith:TanStack Router discarded the returned transition object, so this normal lifecycle condition surfaced as a global unhandled rejection even though navigation completed successfully.
Standalone browser reproduction: https://github.com/David-0x221Eight/tanstack-router-view-transition-repro
Validation
pnpm test:eslintpnpm test:typespnpm test:unitpnpm nx build router-coreSummary by CodeRabbit