Skip to content

Try fixing algolia search for Query again#162

Merged
lachlancollins merged 2 commits into
TanStack:mainfrom
fulopkovacs:fix-algolia-search-again
Jan 26, 2024
Merged

Try fixing algolia search for Query again#162
lachlancollins merged 2 commits into
TanStack:mainfrom
fulopkovacs:fix-algolia-search-again

Conversation

@fulopkovacs

Copy link
Copy Markdown
Member

#160 fixed this route:

When I was making that PR I was unaware of the fact that not all reference docs are in same directory in tanstack/query. We currently have three directories named "reference":

  • docs/framework/react/reference
  • docs/framework/vue/reference
  • docs/reference

@vercel

vercel Bot commented Jan 26, 2024

Copy link
Copy Markdown

@fulopkovacs is attempting to deploy a commit to the Tanstack Team on Vercel.

A member of the Team first needs to authorize it.

@fulopkovacs
fulopkovacs marked this pull request as ready for review January 26, 2024 20:09

@lachlancollins lachlancollins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of this idea?

Comment thread app/routes/query.$version.docs.framework.$framework.$.tsx

@lachlancollins lachlancollins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING 🚀

@fulopkovacs
fulopkovacs force-pushed the fix-algolia-search-again branch from c10df48 to a318227 Compare January 26, 2024 20:20

@lachlancollins lachlancollins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R.e. potential for infinite redirects, can we also change the core-level redirect from '/docs/framework/react/overview' to '/docs/overview'? I'll create a PR to query.

@lachlancollins lachlancollins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry scrap that for now, let's just merge this, it works

@lachlancollins
lachlancollins merged commit 09d9b51 into TanStack:main Jan 26, 2024
LeCarbonator pushed a commit to LeCarbonator/tanstack.com that referenced this pull request Jan 11, 2026
* Try another fix

* If any framework-specific route fails to match, try redirecting to the core equivalent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants