Skip to content

Try fixing algolia search for Query again #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lachlancollins merged 2 commits into from
Jan 26, 2024
Merged

Try fixing algolia search for Query again #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6003c68
Try another fix
fulopkovacs Jan 26, 2024
a318227
If any framework-specific route fails to match, try redirecting to th…
fulopkovacs Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions app/routes/query.$version.docs.$.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,6 @@ export const loader = async (context: LoaderFunctionArgs) => {
const { '*': docsPath, version } = context.params
const { url } = context.request

const reactReferencePages = '/docs/react/reference'
const vueReferencePages = '/docs/vue/reference'

if (url.includes(reactReferencePages)) {
throw redirect(url.replace(reactReferencePages, '/docs/reference'))
}

if (url.includes(vueReferencePages)) {
throw redirect(url.replace(vueReferencePages, '/docs/reference'))
}

// Temporary fix for old docs structure
if (url.includes('/docs/react/')) {
throw redirect(url.replace('/docs/react/', '/docs/framework/react/'))
Expand Down
2 changes: 1 addition & 1 deletion app/routes/query.$version.docs.framework.$framework.$.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const loader = async (context: LoaderFunctionArgs) => {
branch: getBranch(version),
docPath: `docs/framework/${framework}/${docsPath}`,
currentPath: url,
redirectPath: url.replace(/\/docs.*/, '/docs/framework/react/overview'),
Comment thread
lachlancollins marked this conversation as resolved.
redirectPath: url.replace(`/framework/${framework}`, ''),
})
}

Expand Down