Skip to content

fix: restore auto-scaling for collapsed nodes in v2#2108

Open
maxy-shpfy wants to merge 1 commit intomasterfrom
04-21-fix_restore_auto-scaling_for_collapsed_nodes_in_v2
Open

fix: restore auto-scaling for collapsed nodes in v2#2108
maxy-shpfy wants to merge 1 commit intomasterfrom
04-21-fix_restore_auto-scaling_for_collapsed_nodes_in_v2

Conversation

@maxy-shpfy
Copy link
Copy Markdown
Collaborator

@maxy-shpfy maxy-shpfy commented Apr 22, 2026

Description

Introduces a maximum scale cap (MAX_COLLAPSED_SCALE = 7) for collapsed task nodes to prevent them from scaling indefinitely when zooming out. The --collapsed-scale CSS variable is now computed as min(ZOOM_THRESHOLD / zoom, MAX_COLLAPSED_SCALE) and applied alongside the existing --zoom-level variable. Additionally, the perceived font size for collapsed node labels has been increased from 32px to 36px to improve readability at collapsed scale.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Open the flow canvas editor or run view.
  2. Zoom out past the ZOOM_THRESHOLD (0.3) to trigger collapsed node rendering.
  3. Continue zooming out to verify that collapsed node labels no longer grow beyond the capped scale.
  4. Confirm that label text remains legible and does not overflow node boundaries at various zoom levels.

Additional Comments

The MAX_COLLAPSED_SCALE constant is defined in flowCanvasDefaults.ts to keep it consistent and reusable across both the Editor and RunView canvases.

@github-actions
Copy link
Copy Markdown

🎩 Preview

A preview build has been created at: 04-21-fix_restore_auto-scaling_for_collapsed_nodes_in_v2/3319931

Copy link
Copy Markdown
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo the design of the zoomed-out nodes could be improved, but that can be done separately

e.g. what is the cricle for?
image.png

also, I'm 50/50 on the implementation of this feature. zooming out on a complex pipeline leads to a lot of scaled-up tasks overlapping each other

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants