Skip to content

fix: windows state persistence and default layout#2144

Open
maxy-shpfy wants to merge 1 commit into04-22-fix_display_any_validation_issues_including_warnings_in_v2from
04-22-fix_windows_state_persistence_and_default_layout
Open

fix: windows state persistence and default layout#2144
maxy-shpfy wants to merge 1 commit into04-22-fix_display_any_validation_issues_including_warnings_in_v2from
04-22-fix_windows_state_persistence_and_default_layout

Conversation

@maxy-shpfy
Copy link
Copy Markdown
Collaborator

@maxy-shpfy maxy-shpfy commented Apr 23, 2026

Description

First-time users now see only the default preset windows (component-library, recent-runs, pipeline-details) visible on initial load, rather than all windows being shown. This is achieved by checking whether a persisted layout exists in localStorage — if none is found, windows not included in the default view preset are initialized as hidden.

Previously, the debug panel, history, and pipeline tree windows were being explicitly hidden immediately after registration via windows.hideWindow(...). These calls have been removed in favor of the new first-load visibility logic, which handles initial window states more cleanly through resolveInitialState.

DEFAULT_VIEW_PRESET has been exported so it can be referenced during window initialization, and hasPersistedLayout() has been introduced to distinguish first-time users from returning users.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Clear localStorage to simulate a first-time user.
  2. Open the editor and verify that only the component-library, recent-runs, and pipeline-details windows are visible.
  3. Reload the page and verify that the window layout is restored from the persisted state.
  4. As a returning user with an existing layout in localStorage, verify that all previously visible/hidden windows retain their saved states.

Additional Comments

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

🎩 Preview

A preview build has been created at: 04-22-fix_windows_state_persistence_and_default_layout/0fdb4a9

@maxy-shpfy maxy-shpfy marked this pull request as ready for review April 23, 2026 05:13
@maxy-shpfy maxy-shpfy requested a review from a team as a code owner April 23, 2026 05:13
@maxy-shpfy maxy-shpfy force-pushed the 04-22-fix_windows_state_persistence_and_default_layout branch from fdf4946 to 9ef0656 Compare April 23, 2026 05:19
@maxy-shpfy maxy-shpfy force-pushed the 04-22-fix_display_any_validation_issues_including_warnings_in_v2 branch from 1b5f8ce to 2b1ce5e Compare April 23, 2026 05:19
@maxy-shpfy maxy-shpfy force-pushed the 04-22-fix_windows_state_persistence_and_default_layout branch from 9ef0656 to 0fdb4a9 Compare April 23, 2026 05:36
@maxy-shpfy maxy-shpfy force-pushed the 04-22-fix_display_any_validation_issues_including_warnings_in_v2 branch from 2b1ce5e to 7420694 Compare April 23, 2026 05:36
Copy link
Copy Markdown
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants