fix: history redo entries display order#2112
Open
maxy-shpfy wants to merge 1 commit into04-21-fix_validation_of_the_componentref_of_taskfrom
Open
fix: history redo entries display order#2112maxy-shpfy wants to merge 1 commit into04-21-fix_validation_of_the_componentref_of_taskfrom
maxy-shpfy wants to merge 1 commit into04-21-fix_validation_of_the_componentref_of_taskfrom
Conversation
🎩 PreviewA preview build has been created at: |
This was referenced Apr 22, 2026
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 22, 2026
maxy-shpfy
force-pushed
the
04-21-fix_history_redo_entries_display_order
branch
from
66a4318 to
711cfd9
Compare
maxy-shpfy
force-pushed
the
04-21-fix_validation_of_the_componentref_of_task
branch
from
4856021 to
450df9e
Compare
Mbeaulne
approved these changes
Apr 22, 2026
camielvs
approved these changes
Apr 22, 2026
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes incorrect redo step calculation in the history panel. Previously, the redo queue was being reversed before display, and the number of steps forward was calculated using
displayIndex + 1. The redo queue is no longer reversed, and the steps forward calculation is corrected toredoEntries.length - displayIndex, ensuring that clicking a redo entry in the history panel navigates to the correct position in the history.Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Screen Recording 2026-04-22 at 7.56.16 AM.mov (uploaded via Graphite)
Test Instructions
Additional Comments