feat: add Phase 1A English and zh-CN landing localization - #715
Merged
Conversation
lilyshen0722
added
the
blocked-on-Sam-review
lilyshen0722
force-pushed
the
codex/709-zh-cn-phase1
branch
from
July 22, 2026 11:52
7a5bf24 to
151baba
Compare
Two-pass review (voice + web-verified terminology) + adjudication per the new zh-cn-ui-localization skill. Highlights: fork was mistranslated as 创建分支 (=branch); Pod stays English as the product noun; 你 throughout; agent=智能体, memory=记忆, self-host=自托管, metered compute=云端算力. Full change table + locked glossary: commonly-skills/zh-cn-ui-localization. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DMeWzgFxsfBcjoLVLewEES
samxu01
force-pushed
the
codex/709-zh-cn-phase1
branch
from
July 22, 2026 17:39
a38393b to
0af9c41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
react-i18nextinfrastructure for English and Simplified Chinese withv2.langpersistence, navigator detection, English fallback, and<html lang>synchronization<pre>min-content widening adapter cards)Part of #709. This is PR A only; auth and shell/chat chrome intentionally move to PR B after this merges.
Translation review gate
BLOCKED: Sam must complete a native-speaker review of
frontend/src/i18n/locales/zh-CN.jsonbefore merge.The Simplified Chinese copy is machine-drafted and is not represented as native-reviewed. All draft translations are centralized in that single file.
Verification
npm test -- --watchAll=false --runInBand— 60 suites, 259 tests passednpm run build— passednpm ci --ignore-scripts --dry-run— passedRepository-wide lint/typecheck still report pre-existing errors in unchanged files (
PersonalityBuilder.tsx,V2GithubPrCard.tsx, and the existingV2MessageBubble_idtype mismatch); changed-file lint and the production build are green.