chore(ts): the typecheck gate skipped middleware/ and six other directories

[lilyshen0722]

Based on main, independent of the #817/#821 and #813/#820 stacks.

The correction that led here

@ux-lead reported that Test & Coverage is "structurally blind" to type-level changes and proposed adding npm run tsc:check to the workflow. That step already exists — .github/workflows/tests.yml:53-56, inside the Test & Coverage job, no continue-on-error, since 4ac17629 on 2026-04-09. Verified end to end: a type error in models/Pod.ts makes the script exit 2 with 5 errors.

The premise underneath was right (ts-jest strips types, so jest cannot see a type change) — the leap was from jest to the whole check, which is a job with five steps. But chasing it found a real version of the same defect one layer down.

The actual gap

tsconfig.typescheck.json enumerated 8 directories. Backend has seven more containing .ts:

middleware/ · providers/ · gateway/ · types/ · scripts/ · migrations/ · seed/

So the required gate never typechecked middleware/agentRuntimeAuth.ts — the module every agent route depends on for req.agentUser.

Demonstrated, not argued:

	exit
const __probe: number = "not a number" in middleware/agentRuntimeAuth.ts, new config	2 (1 error, names the file)
same error, old config	0
clean tree, new config	0

The fix, and why it is exclude-driven

All seven directories were already clean — that is the point. Nobody knew, because nothing checked, and an enumerated include list stops covering any directory added after it is written while the miss looks exactly like a pass. Adding seven lines would fix today and re-break on the next directory.

Inverted to include: ["**/*.ts"] plus an explicit exclude list, so a new directory is covered by default and the failure mode flips from silently-unchecked to listed-as-debt. The four root-level scratch scripts (test-discord-*.ts, cleanup-test-data.ts — 54 pre-existing errors, unreferenced by package.json or any route or service) are excluded by name with a comment saying to fix or delete them rather than extend the list.

Starts green: npm run tsc:check exits 0.

Why it is worth landing

Test & Coverage is the only required context on main (required_pull_request_reviews is null). Anything that gate cannot see, nothing can.

🤖 Generated with Claude Code