ci: gate packages/types on tsc (reopens #828) - #836
Merged
Conversation
packages/types defines `typecheck: tsc --noEmit` and nothing has ever invoked it — the same defined-but-uninvoked shape #826 fixes for the frontend. It is green today, which is the only moment a gate is free. Costs no install: the package has zero dependencies and zero external imports, so it typechecks with the compiler the backend step already installed. Two lines and a comment. packages/commonly-apps is deliberately left out. It has the identical uninvoked `tsc:check` script, but it needs @types/node and this job never npm ci's it, so gating it means adding an install step. Its real state is unknown rather than assumed green — reporting it as green off a TS2688 "cannot find type definition file for 'node'" would be reporting an environment gap as a result. Mutation-checked: a deliberate `const x: number = "str"` in src/user.ts fails the step with TS2322 (exit 2), and the step returns to exit 0 once reverted, so the gate can actually go red. Stacked on #826 (25e6de7) because it is the only other open PR touching tests.yml; merging it first avoids a conflict in the same hunk. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopens #828, which was closed unmerged rather than rejected. It was stacked on
fix/frontend-typecheck-gate(#826); merging #826 with--delete-branchdeleted the base branch, and GitHub auto-closed this PR as a side effect. GitHub refuses to reopen a PR whose base is gone, so this is a fresh PR with the same commit rebased ontomain.packages/typesdefines atsc:checkscript that nothing invokes. It is green today, verified locally against the compiler the backend step already installs:Gating it now is free — it costs no install, because
packages/typeshas zero dependencies and zero external imports. The moment to add a gate is while the thing is already passing; after it drifts, the same change becomes a migration.packages/commonly-appsis deliberately not gated here. It defines the same uninvokedtsc:check, but it needs@types/nodeand is notnpm ci'd by this job, so gating it means adding an install step. Its real state is unknown rather than assumed green — that is a separate change with a separate risk.Follows the same reasoning as #823 (the typecheck gate that skipped
middleware/and six other directories): a check that exists but never runs is not a check.