add zoot-activate framework#880
add zoot-activate framework#880fwbrasil wants to merge 1 commit intoTechEmpower:masterfrom fwbrasil:master
Conversation
|
@bhauer I think this is good to go, but I couldn't setup a ec2 instance to test it. The software installation fails on a different point at each tentative. Do you have a prepared ec2 image that I can use? |
|
@fwbrasil Not yet. Creating an AMI has been something that we would like to do. I'll chat with the team over here in the coming week to see if we can move that forward. |
|
@bhauer This PR is ready to merge. Is it possible to include for Round 10? Thanks! |
|
@fwbrasil Thanks for this! Yes, we will aim to get this merged in for Round 10. |
|
@bhauer Cool, please let me know if you create an AMI so I can test on ec2 too. |
|
@fwbrasil I think you saw the post by @methane on the Google Group--he has created an AMI for his own testing and made it available for others. I'm just mentioning it here in case others are interested in using that AMI now. In the near future we also plan to have Docker images set up for the three machine roles (application server, database server, and load generator). Our current ETA is later this week. |
|
For whatever reason, when I try to run the tests, I get the following And nothing else. The entire benchmark quits afterward. While you are at it, can you please add or copy over the files that are required by #900? |
|
I was mistaken before - we were having issues with a lot of Scala tests. That has since been resolved. zoot-activate-finagle-postgres, zoot-activate-spray-mongo, zoot-activate-spray-mysql, and zoot-activate-spray-postgres fails all the tests. We also noticed that your setup.py is not always successful in killing the process. Are there any ways that you can increase the success rate? |
|
@aschneider-techempower Thanks for the logs, I'll verify. Do you have a deadline to merge this PR? |
|
There's no hard and fast deadline, but we are currently doing our preliminary tests. It will probably be a couple weeks before we get a benchmark out, but the sooner the better. |
|
@fwbrasil We now have a continuous integration system setup. If you rebase this pull request onto master, then it will automatically verify your changes. We can merge it in as soon as the verification passes :) |
|
Oh, you will also need to edit |
There was a problem hiding this comment.
Please change ../sbt/sbt clean run to $FWROOT/sbt/sbt (from change in #915)
This PR introduces the zoot-activate stack as the replacement for play-activate-mysql.
Related issues:
#707 - Fix the return json for single db query.
#659 - Disable the cache and use eager queries, producing the same amount of database roundtrips as the other implementations.
Permutations:
finagle-mongo
finagle-mysql
finagle-postgres
spray-mongo
spray-mysql
spray-postgres
Related frameworks:
http://github.com/fwbrasil/zoot
http://github.com/fwbrasil/activate
http://github.com/twitter/finagle
http://github.com/spray/spray