-
Notifications
You must be signed in to change notification settings - Fork 4
Add email and unsubscribe filters to admin users search endpoint #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: maximgorbatyuk <13348685+maximgorbatyuk@users.noreply.github.com>
Co-authored-by: maximgorbatyuk <13348685+maximgorbatyuk@users.noreply.github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| public class AdminUsersControllerTests | ||
| { | ||
| [Fact] | ||
| public async Task All_WithEmailFilter_ReturnsMatchingUsers() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test are failing. Please analyze and fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the test failures. The issues were:
-
Compilation errors: Tests were trying to use array indexing
[0]onIReadOnlyCollection<UserDto>which doesn't support indexing. Fixed by using.First()method. -
StyleCop violations: Fixed trailing whitespace, UTF-8 BOM requirements, and string literal issues.
All tests are now passing successfully (commit 832b8d6).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Co-authored-by: maximgorbatyuk <13348685+maximgorbatyuk@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This PR adds two new filter parameters to the admin users search endpoint (
GET /api/admin/users) as requested:UnsubscribeMeFromAllstatusChanges Made
New Query Parameters Class
SearchUsersForAdminQueryParamsthat extendsPageModelto support:email(string) - Optional email filterunsubscribeMeFromAll(bool?) - Optional unsubscribe status filterpage,pageSize)Controller Updates
AdminUsersController.Allmethod to accept the new query parameters.When()extension methodAPI Usage Examples
Test Coverage
Implementation Notes
SearchCompaniesForAdminfeatureFixes #115.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.