Skip to content

fix: improve update status check for stable versions - #46

Closed
DarkSpirit006 wants to merge 2 commits into
TerraByteDev:mainfrom
DarkSpirit006:main
Closed

fix: improve update status check for stable versions#46
DarkSpirit006 wants to merge 2 commits into
TerraByteDev:mainfrom
DarkSpirit006:main

Conversation

@DarkSpirit006

@DarkSpirit006 DarkSpirit006 commented Aug 5, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

  • Bug Fixes
    • Stable update checks now immediately report when the installed version matches the latest stable release.
    • Version matching works reliably by either release name or build ID.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@DarkSpirit006, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 46 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 511994e7-fab0-45a7-b9a2-982b44588372

📥 Commits

Reviewing files that changed from the base of the PR and between 76c06b7 and d2eeee8.

📒 Files selected for processing (1)
  • src/main/java/net/skullian/updater/Updater.java
📝 Walkthrough

Walkthrough

The updater now detects matching stable builds by name or ID and returns an up-to-date status without comparing commit distance.

Changes

Stable version check

Layer / File(s) Summary
Stable version matching
src/main/java/net/skullian/updater/Updater.java
The updater adds isSameStableVersion, which matches stable builds by name or ID. Matching builds skip commit-distance comparison and return an up-to-date status.

Estimated code review effort: 2 (Simple) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the stable-version update status check as the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/main/java/net/skullian/updater/Updater.java`:
- Around line 57-59: Update isSameStableVersion so both comparisons use values
from the same identifier source and producer contract; do not compare
currentBuild.id() with latestBuild.id() because they represent different GitHub
and commit identifiers. Compare matching release names/tags or matching commit
IDs, preserving the intended stable-version equality behavior.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f2b60146-22ee-47c4-b0dd-83f0084e8632

📥 Commits

Reviewing files that changed from the base of the PR and between 344efcf and 76c06b7.

📒 Files selected for processing (1)
  • src/main/java/net/skullian/updater/Updater.java

Comment thread src/main/java/net/skullian/updater/Updater.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant