Skip to content

Improve update status check for stable version comparisons - #47

Open
DarkSpirit006 wants to merge 2 commits into
TerraByteDev:mainfrom
DarkSpirit006:main
Open

Improve update status check for stable version comparisons#47
DarkSpirit006 wants to merge 2 commits into
TerraByteDev:mainfrom
DarkSpirit006:main

Conversation

@DarkSpirit006

@DarkSpirit006 DarkSpirit006 commented Aug 5, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

  • Bug Fixes
    • Improved stable update checks to correctly recognize matching releases as up to date.
    • Stable builds now more accurately determine whether a newer version is available.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6e1d2fd3-914c-41f3-963b-71a2beee3a7e

📥 Commits

Reviewing files that changed from the base of the PR and between 344efcf and d2eeee8.

📒 Files selected for processing (1)
  • src/main/java/net/skullian/updater/Updater.java

📝 Walkthrough

Walkthrough

Stable update checks now recognize matching release names or IDs as current. When releases differ, stable update distance uses release names instead of numeric IDs.

Changes

Stable Version Matching

Layer / File(s) Summary
Stable update comparison
src/main/java/net/skullian/updater/Updater.java
The updater adds isSameStableVersion and returns an up-to-date status when release names or IDs match. Different stable releases use names for version comparison.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the stable-version update status improvements in the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant