-
Notifications
You must be signed in to change notification settings - Fork 0
⭐ Code Review Audit
A per-module, per-file code review of all 13 added modules, run for real — a GitHub issue, a branch, and a merged PR for every source file, not a simulated pass. Parent tracking issue #32, one sub-issue per module (#33–#45). One module worked at a time, in the order modules were originally added.
Status: store complete — 27/27 files, 3 real bugs found and fixed, 1 test-coverage gap closed. entity complete — 9/9 files, 0 real bugs, 2 structural observations recorded. effects complete — 18/18 files, 0 real bugs found. router-store complete — 12/12 files, 7 real bugs found and fixed, the highest hit rate of any module so far (type-level declared-vs-actual mismatches, a false JSDoc claim caught by un-skipping a disabled test, and a field silently sourced from the wrong object). store-devtools in progress — 3/11 files reviewed, 1 real bug found and fixed (createConfig() was mutating the caller's own features object). 8 modules still queued after store-devtools. The type-level gap that let router-store's bugs through was significant enough to spawn its own tracking work — parent issue #162 with one child issue per module (#163–#175), adding type-check tests alongside this file-by-file review rather than as an afterthought.
All 3 real bugs found in store share one shape: a function's top-level entry point missing a null-state guard its own recursive/nested-value logic already had (freeze(), getUnserializable(), combineReducers()) — inherited from the original upstream import, not introduced by this repo, each reproduced with a failing regression test before being fixed. Full findings index, file by file, is docs/code-review.md; live per-file tracking table is in todo.md.