-
Notifications
You must be signed in to change notification settings - Fork 0
⭐ Router Store
@ngrx/router-store — real source, 168/168 tests passing (1 skipped), 0 lint errors. Surfaced a real composition-over-inheritance ripple: 3 call sites, in both production code and specs, relied on Store/ActionsSubject surface that the redesign had already removed — fixed by adapting to the composed state$/asObservable() API instead.
This is the second module (after effects) to hit the predicted ripple from the store redesign, confirming the fix generalizes rather than being a one-off adaptation specific to effects.
The code review audit is complete on this module — 12/12 files, 7 real bugs found and fixed, the highest hit rate of any module in the audit so far: mostly declared-type-vs-actual-value mismatches no runtime test had caught, plus a false JSDoc claim about reducer-thrown errors canceling navigation (caught by un-skipping a test that had been silently disabled) and a field (FullRouterStateSerializer's component) silently sourced from the wrong object.