Skip to content

Clean namespace#62

Merged
MehdiK merged 5 commits intoTestStack:masterfrom
MehdiK:clean-namespace
Mar 20, 2014
Merged

Clean namespace#62
MehdiK merged 5 commits intoTestStack:masterfrom
MehdiK:clean-namespace

Conversation

@MehdiK
Copy link
Copy Markdown
Member

@MehdiK MehdiK commented Mar 17, 2014

based on #61

This is not to be merged but rather to be used to discuss different options. What do you think?

cc @mwhelan

@mwhelan
Copy link
Copy Markdown
Member

mwhelan commented Mar 18, 2014

I like the promotion of Reporters from within Processors. The removal of Core is a bit more interesting. It takes some adjusting to get used to them in the root, but I think it makes sense. Overall, I think I quite like this approach. Most things seem to be in the namespace that corresponds to their folder location. The only exception is Scanners, but that is a good exception. I like that Scanners are physically grouped in their own folder but have TestStack.BDDfy namespace for optimal discoverability and namespace explosion in consuming code.

@MehdiK
Copy link
Copy Markdown
Member Author

MehdiK commented Mar 19, 2014

I am a bit unsure about Core bits too. You think they should be moved back to a Core folder with no namespace? On the other hand, I thought having the core bits out and make them visible on the very first look may make the code more approachable for the new-comer!

Thoughts?

@mwhelan
Copy link
Copy Markdown
Member

mwhelan commented Mar 19, 2014

I think it's quite an aesthetic thing really. I don't necessarily think
it's more discoverable in the root, but I'm happy either way.

On Wed, Mar 19, 2014 at 5:12 AM, Mehdi Khalili notifications@github.comwrote:

I am a bit unsure about Core bits too. You think they should be moved back
to a Core folder with no namespace? On the other hand, I thought having the
core bits out and make them visible on the very first look may make the
code more approachable for the new-comer!

Thoughts?

Reply to this email directly or view it on GitHubhttps://github.com//pull/62#issuecomment-38018551
.

MehdiK added a commit that referenced this pull request Mar 20, 2014
@MehdiK MehdiK merged commit 87eb80d into TestStack:master Mar 20, 2014
@MehdiK MehdiK deleted the clean-namespace branch March 20, 2014 12:26
@MehdiK MehdiK mentioned this pull request Mar 20, 2014
@mwhelan mwhelan mentioned this pull request Apr 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants