Skip to content

Release notes#99

Merged
MehdiK merged 4 commits intoTestStack:masterfrom
MehdiK:release-notes
Apr 9, 2014
Merged

Release notes#99
MehdiK merged 4 commits intoTestStack:masterfrom
MehdiK:release-notes

Conversation

@MehdiK
Copy link
Copy Markdown
Member

@MehdiK MehdiK commented Apr 8, 2014

Some suggestions on top of #96

@mwhelan
Copy link
Copy Markdown
Member

mwhelan commented Apr 9, 2014

These changes are a big improvement.

Comment thread release-notes.md
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These breaking changes should be added to a readme.txt shipped with the NuGet package

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I think we should just package the entire release-notes file with the nuget so users know what's being added over time. Thoughts?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes sense to stick to the one file to maintain.

On Wed, Apr 9, 2014 at 9:26 AM, Mehdi Khalili notifications@github.comwrote:

In release-notes.md:

@@ -1,4 +1,27 @@
-###In development
+##V4 In Development
+
+####Improvements

  • - #61 & #62 - rationalized BDDfy namespaces to require less namespaces for some features and to make features more discoverable. Breaking Change

Good idea. I think we should just package the entire release-notes file
with the nuget so users know what's being added over time. Thoughts?

Reply to this email directly or view it on GitHubhttps://github.com//pull/99/files#r11426714
.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build could just copy the releasenotes to readme.txt?

Maybe even insert a welcome to BDDfy thing above the release notes as well

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh I have a fundamental issue with readme in nuget packages and that is they overwrite each other (or at least did the last time I checked)! BDDfy used to have a readme called bddfy-readme.md.

I think/thought having a readme in the nuget is a good idea; but it's also maintenance nightmare in that any time there was a breaking change I had to update a few files around the place.

MehdiK added a commit that referenced this pull request Apr 9, 2014
@MehdiK MehdiK merged commit 514fb51 into TestStack:master Apr 9, 2014
@MehdiK MehdiK deleted the release-notes branch April 9, 2014 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants