[DRT] Remove param file from flow test - #677
Merged
rovinski merged 2 commits intoMay 25, 2021
Merged
Conversation
rovinski
marked this pull request as ready for review
May 25, 2021 20:22
eder-matheus
pushed a commit
that referenced
this pull request
Jul 27, 2026
hermetic-llvm 0.8.14 enables the cc_toolchain coverage features and declares gcov / llvm-cov / llvm-profdata as toolchain files (hermeticbuild/hermetic-llvm #675, fixed by #677), so instrumentation, tool staging into the test sandbox and LLVM_COV/LLVM_PROFDATA all come from the toolchain. Remove the hand-rolled instrumentation copts/linkopts, the two --test_env paths that hardcoded the LLVM release (they broke on every module bump) and --strategy=TestRunner=local: coverage tests run sandboxed again. Add --noexperimental_fetch_all_coverage_outputs to work around a rules_cc bug (dangling `gcov` symlink in each test's raw _coverage tree in llvm mode); drop it once rules_cc >= 0.2.23 (bazelbuild/rules_cc#795) is released. 0.8.14 still pins LLVM 22.1.8, so the compiler is unchanged. Verified: `bazelisk coverage --config=coverage -- //src/utl/test:cpp_tests` passes 4/4 sandboxed, combined lcov report has 1464 DA: lines across 57 files (all under src/), genhtml renders 39.6% lines / 44.2% functions -- identical to the numbers from the original coverage config. `bazelisk build //:openroad` succeeds. Signed-off-by: SombraSoft <sombrio@sombrasoft.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.