Fix accidental use of function meant to remove() a file.
#8154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzeller
force-pushed
the
feature-20250829-fix-file-remove
branch
2 times, most recently
from
874b485 to
ddd946c
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
hzeller
force-pushed
the
feature-20250829-fix-file-remove
branch
from
ddd946c to
8e518a8
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Member
|
Could you switch to std::filesystem::remove and remove the need for the waiver? |
hzeller
force-pushed
the
feature-20250829-fix-file-remove
branch
from
8e518a8 to
13110a2
Compare
Contributor
Author
|
yep. Done. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
* `std::remove` is an `<algorithm>` * `remove()` is meant to remove a file (defined in `<stdio.h>`). Use `std::filsystem::remove()` instead. Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
force-pushed
the
feature-20250829-fix-file-remove
branch
from
13110a2 to
c99d457
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
In #8158 , I am also removing the other uses of |
maliberty
approved these changes
Aug 29, 2025
hzeller
added a commit
to hzeller/OpenROAD
that referenced
this pull request
Aug 29, 2025
Follow-up change to The-OpenROAD-Project#8154 : use modern `std::filesystem::remove()` instead of old-school `remove()` from stdio.h Signed-off-by: Henner Zeller <h.zeller@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::removeis an<algorithm>remove()is meant to remove a file, declared in<stdio.h>(not<cstdio>, interestingly).