Don't use stdio.h remove(), but std::filesystem::remove() instead. #8158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzeller
force-pushed
the
feature-20250829-no-stdio-remove
branch
from
aad329b to
66546ab
Compare
Contributor
Author
|
this is in the other places that used the |
maliberty
approved these changes
Aug 29, 2025
Member
|
conflict to resolve |
Follow-up change to The-OpenROAD-Project#8154 : use modern `std::filesystem::remove()` instead of old-school `remove()` from stdio.h Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
force-pushed
the
feature-20250829-no-stdio-remove
branch
from
66546ab to
65b3b6e
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
conflict resolved, ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up change to #8154 : use modern
std::filesystem::remove()instead of old-schoolremove()from stdio.h