ci(deps): bump cosign-installer to v4.1.2, pin cosign CLI to v2.5.2#86
Merged
Conversation
Supersedes Dependabot #59. Bumping sigstore/cosign-installer from v3 to v4.1.2 changes its default cosign CLI to v3.0.6, which removed the sign-blob --output-signature / --output-certificate flags the release signing step uses (v3 replaced them with --bundle). Pinning cosign-release to v2.5.2 keeps the detached .sig/.pem signing working while taking the updated installer action.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #59.
Dependabot #59 bumps
sigstore/cosign-installerv3 → v4.1.2. That installer's default cosign CLI is v3.0.6, which removed thesign-blob --output-signature/--output-certificateflags used by the release signing step (v3 replaced them with--bundle). Because that step swallows failures in aWrite-Warning, a blind bump would silently ship releases with no.sig/.pemsignatures and drop the Signed-Releases posture.This PR takes the installer bump and pins the cosign CLI to
v2.5.2viacosign-release, so detached signing keeps working unchanged. Closes out #59.