Skip to content

Conversation

@Panquesito7
Copy link
Member

@Panquesito7 Panquesito7 commented Jun 23, 2020

Description of Change

Various LGTM fixes - #880

Checklist

  • Added description of change
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@lgtm-com
Copy link

lgtm-com bot commented Jun 23, 2020

This pull request fixes 4 alerts when merging bd14502 into d958eec - view on LGTM.com

fixed alerts:

  • 4 for Short global name

@Panquesito7
Copy link
Member Author

Both issues should be fixed now.

@lgtm-com
Copy link

lgtm-com bot commented Jun 23, 2020

This pull request introduces 1 alert and fixes 4 when merging 18132b9 into d958eec - view on LGTM.com

new alerts:

  • 1 for 'new[]' array freed with 'delete'

fixed alerts:

  • 4 for Short global name

Copy link
Collaborator

@kvedala kvedala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think?
We can do this because, the past values of the series are not being used at all. The main function is simply printing them in series. So, why to even store the values?

@lgtm-com
Copy link

lgtm-com bot commented Jun 23, 2020

This pull request fixes 4 alerts when merging d2f6a49 into d958eec - view on LGTM.com

fixed alerts:

  • 4 for Short global name

@Panquesito7
Copy link
Member Author

All issues should be fixed now.
Thanks, @kvedala! 🙂

@kvedala
Copy link
Collaborator

kvedala commented Jun 23, 2020

please ensure all codes

  1. compile
  2. execute
  3. return values as expected

@lgtm-com
Copy link

lgtm-com bot commented Jun 23, 2020

This pull request fixes 4 alerts when merging 6044411 into d958eec - view on LGTM.com

fixed alerts:

  • 4 for Short global name

@kvedala
Copy link
Collaborator

kvedala commented Jun 23, 2020

@mishraabhinn @ayaankhan98 please review as well. Thanks

@Panquesito7
Copy link
Member Author

@kvedala all programs seem to be running fine, thanks.
However, the parenthesis_matching.cpp program always prints Wrong Expression, no matter what I type.

@kvedala
Copy link
Collaborator

kvedala commented Jun 23, 2020

@kvedala all programs seem to be running fine, thanks.
However, the parenthesis_matching.cpp program always prints Wrong Expression, no matter what I type.

try this input:
{{(())}}

@lgtm-com
Copy link

lgtm-com bot commented Jun 24, 2020

This pull request fixes 4 alerts when merging 72fad26 into d958eec - view on LGTM.com

fixed alerts:

  • 4 for Short global name

@Panquesito7
Copy link
Member Author

Thank you, it worked.
Everything seems to be fine with all programs.

@Panquesito7 Panquesito7 requested a review from kvedala June 24, 2020 17:40
@Panquesito7 Panquesito7 mentioned this pull request Jun 24, 2020
8 tasks
@lgtm-com
Copy link

lgtm-com bot commented Jun 24, 2020

This pull request fixes 4 alerts when merging 4c6b3b8 into d958eec - view on LGTM.com

fixed alerts:

  • 4 for Short global name

@kvedala kvedala merged commit 46854f5 into TheAlgorithms:master Jun 24, 2020
@Panquesito7 Panquesito7 deleted the lgtm_fixes branch June 24, 2020 21:00
@Panquesito7 Panquesito7 added approved Approved; waiting for merge bugfix Correction to existing algorithms labels Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Approved; waiting for merge bugfix Correction to existing algorithms

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants