-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
fix: Various LGTM fixes #890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request fixes 4 alerts when merging bd14502 into d958eec - view on LGTM.com fixed alerts:
|
|
Both issues should be fixed now. |
|
This pull request introduces 1 alert and fixes 4 when merging 18132b9 into d958eec - view on LGTM.com new alerts:
fixed alerts:
|
kvedala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think?
We can do this because, the past values of the series are not being used at all. The main function is simply printing them in series. So, why to even store the values?
|
This pull request fixes 4 alerts when merging d2f6a49 into d958eec - view on LGTM.com fixed alerts:
|
|
All issues should be fixed now. |
|
please ensure all codes
|
|
This pull request fixes 4 alerts when merging 6044411 into d958eec - view on LGTM.com fixed alerts:
|
|
@mishraabhinn @ayaankhan98 please review as well. Thanks |
|
@kvedala all programs seem to be running fine, thanks. |
try this input: |
|
This pull request fixes 4 alerts when merging 72fad26 into d958eec - view on LGTM.com fixed alerts:
|
|
Thank you, it worked. |
|
This pull request fixes 4 alerts when merging 4c6b3b8 into d958eec - view on LGTM.com fixed alerts:
|
Description of Change
Various LGTM fixes - #880
Checklist
Notes: