Skip to content

feat: initial lgtm.yml #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kvedala wants to merge 3 commits into from
Closed

feat: initial lgtm.yml #897

kvedala wants to merge 3 commits into from

Conversation

@kvedala
Copy link
Collaborator

@kvedala kvedala commented Jun 24, 2020

Description of Change

Ability to check and analysis code quality using lgtm.com

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@kvedala kvedala mentioned this pull request Jun 24, 2020
Closed
@kvedala kvedala linked an issue Jun 24, 2020 that may be closed by this pull request
[FEATURE] Code quality checks #898
Closed
@kvedala kvedala mentioned this pull request Jun 24, 2020
Merged
8 tasks
@Panquesito7
Copy link
Member

Panquesito7 commented Jun 24, 2020

PR #890, build logs.

@lgtm-com
Copy link

lgtm-com bot commented Jun 24, 2020

This pull request introduces 1 alert when merging 2bc4b26 into ddb166e - view on LGTM.com

new alerts:

  • 1 for Unsigned comparison to zero

@lgtm-com
Copy link

lgtm-com bot commented Jun 25, 2020

This pull request introduces 1 alert when merging 8abbc13 into 6365881 - view on LGTM.com

new alerts:

  • 1 for Unsigned comparison to zero

kvedala added a commit to kvedala/C-Plus-Plus that referenced this pull request Jun 25, 2020
@kvedala
fix self-tests and unsigned comparision to zero
5939792 
refer TheAlgorithms#897 and https://lgtm.com/projects/g/TheAlgorithms/C-Plus-Plus/rev/pr-f6e7cda8faf908e87511f30e782190233bdee68c
@kvedala kvedala mentioned this pull request Jun 25, 2020
Merged
8 tasks
@kvedala kvedala added the on hold Pull request is temporarily not reviewed label Jun 25, 2020
@kvedala kvedala marked this pull request as draft June 25, 2020 23:26
@kvedala kvedala removed the on hold Pull request is temporarily not reviewed label Jun 28, 2020
@kvedala kvedala marked this pull request as ready for review June 28, 2020 13:01
cclauss
cclauss approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LLTM

@kvedala
Copy link
Collaborator Author

kvedala commented Jul 21, 2020 •
edited
Loading

Not required as LGTM "remembered" the original settings I had placed. Can always be revived if needed in the future.

@kvedala kvedala closed this Jul 21, 2020
@kvedala kvedala deleted the add_lgtm.yml branch July 21, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] Code quality checks

3 participants

@kvedala @Panquesito7 @cclauss