Skip to content

Conversation

@fhlasek
Copy link
Contributor

@fhlasek fhlasek commented Aug 3, 2020

Description of Change

Continuation of #954 and #983. Addresses #932.

Checklist

  • Added description of change
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@Panquesito7
Copy link
Member

Please, pick one file at a time, not more than five.
We will do much better job improving file by file.

Thank you.

@Panquesito7
Copy link
Member

Sounds good to me. We can merge this to enable CI and continue
improving the code and adding documentation in another PR. 👍

@fhlasek
Copy link
Contributor Author

fhlasek commented Aug 15, 2020

@Panquesito7 @kvedala @ayaankhan98 do you want me to continue splitting files one by one or do you think it's manageable at the current size?

@kvedala
Copy link
Collaborator

kvedala commented Aug 15, 2020

@Panquesito7 @kvedala @ayaankhan98 do you want me to continue splitting files one by one or do you think it's manageable at the current size?

Maybe we can split a couple of more files, so that this repo contains a single digit of modified files? Thank you @fhlasek

@kvedala kvedala self-requested a review August 17, 2020 13:32
Copy link
Collaborator

@kvedala kvedala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good otherwise
Great work, @fhlasek

@fhlasek fhlasek requested review from Panquesito7 and kvedala August 18, 2020 04:43
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@Panquesito7 Panquesito7 added the approved Approved; waiting for merge label Aug 18, 2020
@kvedala kvedala requested a review from ayaankhan98 August 18, 2020 19:04
@ayaankhan98
Copy link
Member

great work @fhlasek
Thanks for your contribution!

@ayaankhan98 ayaankhan98 merged commit dfe5bd7 into TheAlgorithms:master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Approved; waiting for merge Improvement improvement in previously written codes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants