-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
fhlasek/fixgraph: refactor of graph/ to follow the linter style #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Krishna Vedala <7001608+kvedala@users.noreply.github.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Please, pick one file at a time, not more than five. Thank you. |
|
Sounds good to me. We can merge this to enable CI and continue |
|
@Panquesito7 @kvedala @ayaankhan98 do you want me to continue splitting files one by one or do you think it's manageable at the current size? |
Maybe we can split a couple of more files, so that this repo contains a single digit of modified files? Thank you @fhlasek |
kvedala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good otherwise
Great work, @fhlasek
Panquesito7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
|
great work @fhlasek |
Description of Change
Continuation of #954 and #983. Addresses #932.
Checklist