Skip to content

'Fixes #3199'#3228

Merged
siriak merged 73 commits intoTheAlgorithms:masterfrom
siddhant2002:master
Aug 24, 2022
Merged

'Fixes #3199'#3228
siriak merged 73 commits intoTheAlgorithms:masterfrom
siddhant2002:master

Conversation

@siddhant2002
Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • [] Fix a bug or typo in an existing algorithm?
  • [] Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Copy Markdown
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please uncomment tests and fix the build check? Everything else looks good

@siddhant2002
Copy link
Copy Markdown
Contributor Author

ok

@siddhant2002
Copy link
Copy Markdown
Contributor Author

@siriak please check the updated pr

Copy link
Copy Markdown
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit 2ffcff1 into TheAlgorithms:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants