added the error type#2
Merged
Merged
Conversation
edwh
added a commit
that referenced
this pull request
Apr 24, 2026
Import notifications.js into the global bundle so the AJAX click handler is registered. Without it the btn-marked link fell through to a full page navigation that appeared to do nothing. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
edwh
added a commit
that referenced
this pull request
Jul 22, 2026
Four issues from the preview, all confirmed against develop. 1. Dead session shows a dashboard error instead of redirecting to login. The console evidence (GET /api/v2/users/me/events 401, "/" redirecting to /dashboard) is a token present in localStorage - loggedIn (=!!token) true, so the guard admits it - while the session behind it is invalid, common on a preview whose DB was reset so the token maps to a deleted user. BaseAPI only clears auth on a /session *401*; a 500, or a /session that returns a null user for a bad token, left the token in place. The cold-boot session plugin now clears the token on ANY failed resolve OR a null-user response, so the whole app - guard, navbar, the "/" redirect - consistently treats it as a guest and routes to /login. Two tests pin this. 2. Logged-out Sign in / Join buttons. develop writes plain anchors with inline styles the .btn classes were fighting: square corners (we rendered a pill radius), a 10px gap between them (they were touching), Sign in white with a 2px black border, Join solid black. All re-asserted to match, sentence case per develop's text-transform: initial. 3. Language bar was not full width - AppFooter wrapped it in Bootstrap's .container, capping it to the content max-width. Removed; the bar is now width:100% with develop's top border, matching _languages.scss. 4. Language bar sat mid-page on short pages instead of pinned to the bottom. develop sets <body class="fixed-layout"> in BOTH header.blade.php (app pages) and header_plain.blade.php (guest), and .fixed-layout .language-bar is position:fixed;bottom:0;z-index:10 - i.e. pinned on every page, with the body padded 65px so it never covers content. An earlier fix scoped this to guest pages only; generalised it to every page as develop does. The dashboard error box (#2 of the reported set) is left as-is: once the dead session redirects to /login it no longer appears in that flow, and develop server-renders the dashboard so there is no SPA error box to match against. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011Ye3otsxm9RiHHDKcC3TJA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added the error type to error pages