chore(crcdebug): Log DieOnDetonate on projectile detonation - #3056
Closed
Okladnoj wants to merge 1 commit into
Closed
chore(crcdebug): Log DieOnDetonate on projectile detonation#3056Okladnoj wants to merge 1 commit into
Okladnoj wants to merge 1 commit into
Conversation
addCRCDebugLineNoCounter had no macro wrapper, so it could not be used. Add CRCDEBUG_LOG_NOCOUNTER next to CRCDEBUG_LOG and use it in MissileAIUpdate::detonate to record the weapon's DieOnDetonate flag. The flag decides whether the projectile dies right there or a frame later in doKillSelfState, which moves its die modules to a different frame, so two clients that disagree on it desync at that frame. The no-counter variant keeps the ordinals in the frame identical to a client without this change.
Okladnoj
force-pushed
the
okji/debug/crc-dieondetonate
branch
from
August 3, 2026 17:08
511e36d to
4e5e0b9
Compare
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addCRCDebugLineNoCounterexists but has no macro wrapper, so it cannot be used. This addsCRCDEBUG_LOG_NOCOUNTERnext toCRCDEBUG_LOG.MissileAIUpdate::detonateuses it to record the weapon'sDieOnDetonateflag. The flag decides whetherthe projectile dies right there or a frame later in
doKillSelfState, which moves its die modules to adifferent frame. Two clients that disagree on it desync at that frame, and nothing in the CRC dump pointed
at the flag. The no-counter variant keeps the ordinals in the frame identical to a client without this
change, so the log itself cannot shift a comparison.
Debug builds only, no effect on release.
Todo:
MissileCallsOnDiedoes not exist in Generals